drop test / function

Author: jeremiahpslewis

src/samplers.jl

@@ -184,7 +184,7 @@ function StatsBase.sample(nbs::NStepBatchSampler, ts, ::Val{SS′ART}, inds)
         s = ts[:state][inds]
         s′ = ts[:next_state][inds.+(nbs.n-1)]
     else
-        s = ts[:state][[x + i + 1 for i in -nbs.stack_size+1:0, x in inds]]
+        s = ts[:state][[x + i for i in -nbs.stack_size+1:0, x in inds]]
         s′ = ts[:next_state][[x + nbs.n - 1 + i for i in -nbs.stack_size+1:0, x in inds]]
     end
 
@@ -220,12 +220,3 @@ function StatsBase.sample(s::NStepBatchSampler{names}, e::EpisodesBuffer{<:Any,
         StatsBase.sample(s, t.traces, Val(names), inds)
     )
 end
-
-function StatsBase.sample(s::NStepBatchSampler{names}, t::CircularPrioritizedTraces) where {names}
-    inds, priorities = rand(s.rng, t.priorities, s.batch_size)
-
-    merge(
-        (key=t.keys[inds], priority=priorities),
-        StatsBase.sample(s, t.traces, Val(names), inds)
-    )
-end

test/samplers.jl

@@ -135,30 +135,6 @@ end
     @test xs3.reward[1] ≈ 3 + γ * 4  # terminated at step 4
     @test xs3.reward[2] ≈ 5 + γ * (6 + γ * 7)
     @test xs3.reward[3] ≈ 7 + γ * (8 + γ * 9)
-
-    @testset "CircularPrioritizedTraces with NStepBatchSampler" begin
-        γ = 0.9
-        n_stack = 2
-        n_horizon = 3
-        batch_size = 4
-    
-        t = CircularPrioritizedTraces(
-            CircularArraySARTSATraces(;
-                capacity=10
-            ),
-            default_priority=1.0f0
-        )
-        s = NStepBatchSampler(n=n_horizon, γ=γ, stack_size=n_stack, batch_size=batch_size)
-        push!(t, (state = 1, action = true))
-        for i = 1:9
-            push!(t, (state = i+1, action = true, reward = i, terminal = false))
-        end
-    
-        xs = RLTrajectories.StatsBase.sample(s, t)
-        @test haskey(xs, :state)
-        @test haskey(xs, :priority)
-        @test haskey(xs, :key)
-    end    
 end
 #! format: on