remove more dead code

Author: chriselrod

Project.toml

@@ -1,7 +1,7 @@
 name = "LoopVectorization"
 uuid = "bdcacae8-1622-11e9-2a5c-532679323890"
 authors = ["Chris Elrod <[email protected]>"]
-version = "0.12.112"
+version = "0.12.113"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/codegen/lower_threads.jl

@@ -463,8 +463,8 @@ function thread_one_loops_expr(
       push!(loopboundexpr.args, looprange)
       push!(lastboundexpr.args, lastrange)
     else
-      loop_boundary!(loopboundexpr, ls, loop, true)
-      loop_boundary!(lastboundexpr, ls, loop, true)
+      loop_boundary!(loopboundexpr, loop, true)
+      loop_boundary!(lastboundexpr, loop, true)
     end
   end
   avxcall_args = Expr(:tuple, lastboundexpr, Symbol("#vargs#"))
@@ -676,8 +676,8 @@ function thread_two_loops_expr(
       push!(loopboundexpr.args, looprange2)
       push!(lastboundexpr.args, lastrange2)
     else
-      loop_boundary!(loopboundexpr, ls, loop, true)
-      loop_boundary!(lastboundexpr, ls, loop, true)
+      loop_boundary!(loopboundexpr, loop, true)
+      loop_boundary!(lastboundexpr, loop, true)
     end
   end
   avxcall_args = Expr(:tuple, lastboundexpr, Symbol("#vargs#"))

src/codegen/split_loops.jl

@@ -156,7 +156,6 @@ function lower_and_split_loops(ls::LoopSet, inline::Int)
     order_2, unrolled_2, tiled_2, vectorized_2, U_2, T_2, cost_2, shouldinline_2 =
       choose_order_cost(ls_2)
     # U_1 = T_1 = U_2 = T_2 = 2
-    # return ls_1, ls_2
     if cost_1 + cost_2 + looplenpen * (looplengthprod(ls_1) + looplengthprod(ls_2)) ≤
        muladd(0.9, cost_fused, ls_looplen)
       ls_2_lowered = if length(remaining_ops) > 1

src/condense_loopset.jl

@@ -218,7 +218,6 @@ function OperationStruct!(
   ls::LoopSet,
   op::Operation,
 )
-  instr = instruction(op)
   ld = loopdeps_uint(ls, op)
   rd = reduceddeps_uint(ls, op)
   cd = childdeps_uint(ls, op)
@@ -241,7 +240,7 @@ end
 @inline zerorangestart(r::ArrayInterface.OptionallyStaticUnitRange{StaticInt{1}}) =
   CloseOpen(maybestaticlast(r))
 
-function loop_boundary!(q::Expr, ls::LoopSet, loop::Loop, shouldindbyind::Bool)
+function loop_boundary!(q::Expr, loop::Loop, shouldindbyind::Bool)
   if isstaticloop(loop) || loop.rangesym === Symbol("")
     call = Expr(:call, :(:))
     f = gethint(first(loop))
@@ -265,7 +264,7 @@ end
 function loop_boundaries(ls::LoopSet, shouldindbyind::Vector{Bool})
   lbd = Expr(:tuple)
   for (ibi, loop) ∈ zip(shouldindbyind, ls.loops)
-    loop_boundary!(lbd, ls, loop, ibi)
+    loop_boundary!(lbd, loop, ibi)
   end
   lbd
 end
@@ -770,8 +769,11 @@ function generate_call_types(
   ops = operations(ls)
   for op ∈ ops
     instr::Instruction = instruction(op)
-    if ((isconstant(op) && (instr == LOOPCONSTANT)) && (!roots[identifier(op)]))
-      instr = op.instruction = DROPPEDCONSTANT
+    if (!roots[identifier(op)])
+      if (isconstant(op) && (instr == LOOPCONSTANT)) || !isconstant(op)
+        instr = op.instruction = DROPPEDCONSTANT
+        op.node_type = constant
+      end
     end
     push!(operation_descriptions.args, QuoteNode(instr.mod))
     push!(operation_descriptions.args, QuoteNode(instr.instr))

src/precompile.jl

@@ -2292,7 +2292,7 @@ function _precompile_()
       Tuple{StaticInt{1},Int},
     },
   )   # time: 0.001156726
-  Base.precompile(Tuple{typeof(loop_boundary!),Expr,LoopSet,Loop,Bool})   # time: 0.001152516
+  Base.precompile(Tuple{typeof(loop_boundary!),Expr,Loop,Bool})   # time: 0.001152516
   Base.precompile(Tuple{typeof(maybestatic!),Expr})   # time: 0.001151616
   Base.precompile(Tuple{typeof(tuple_expr),typeof(identity),Vector{Tuple{Int,NumberType}}})   # time: 0.001148223
   Base.precompile(