Skip to content

fix: #395, check if loop body is a block and warp it if not #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2022
Merged

fix: #395, check if loop body is a block and warp it if not #396

merged 4 commits into from
Apr 9, 2022

Conversation

wangl-cc
Copy link
Contributor

@wangl-cc wangl-cc commented Apr 9, 2022

There are four macros which will generate loop whose body is not a block. The gen_loop_issue395 and gen_A_mul_B macro cause StackOverflowError in current master while the gen_single_loop and gen_nest_loop cause LoadError: TypeError: in typeassert, expected Int64, got a value of type Static.StaticInt{1}. I have no idea about these errors, but warp those loop body as a block that fixes all of these error.

Copy link
Member

@chriselrod chriselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind bumping the patch version?

@wangl-cc
Copy link
Contributor Author

wangl-cc commented Apr 9, 2022

@chriselrod Should I squash?

@chriselrod chriselrod enabled auto-merge (squash) April 9, 2022 16:38
@chriselrod
Copy link
Member

@chriselrod Should I squash?

I enabled auto-merge squash, so it'll automatically merge once tests pass.
I'll have to re-enable it if you push any new commits, though.

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #396 (07c702c) into master (77d0efb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   87.19%   87.21%   +0.01%     
==========================================
  Files          38       38              
  Lines        9499     9508       +9     
==========================================
+ Hits         8283     8292       +9     
  Misses       1216     1216              
Impacted Files Coverage Δ
src/constructors.jl 98.36% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d0efb...07c702c. Read the comment docs.

@wangl-cc
Copy link
Contributor Author

wangl-cc commented Apr 9, 2022

I don't know reason, it seams that Meta.isexpr break the fix. The != works see https://github.com/wangl-cc/LoopVectorization.jl/runs/5955789898?check_suite_focus=true.

I'm sorry, I forget a !.

auto-merge was automatically disabled April 9, 2022 16:57

Head branch was pushed to by a user without write access

@chriselrod
Copy link
Member

I don't know reason, it seams that Meta.isexpr break the fix. The != works see https://github.com/wangl-cc/LoopVectorization.jl/runs/5955789898?check_suite_focus=true.

I'm sorry, I forget a !.

My bad, I think I didn't have it in my comment.

@chriselrod chriselrod enabled auto-merge (squash) April 9, 2022 17:52
@chriselrod chriselrod disabled auto-merge April 9, 2022 19:59
@chriselrod chriselrod merged commit 4748b14 into JuliaSIMD:master Apr 9, 2022
@chriselrod
Copy link
Member

Thanks!

@wangl-cc wangl-cc deleted the issue-395 branch April 10, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants