-
Notifications
You must be signed in to change notification settings - Fork 71
fix: #395, check if loop body is a block and warp it if not #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind bumping the patch version?
@chriselrod Should I squash? |
I enabled auto-merge squash, so it'll automatically merge once tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 87.19% 87.21% +0.01%
==========================================
Files 38 38
Lines 9499 9508 +9
==========================================
+ Hits 8283 8292 +9
Misses 1216 1216
Continue to review full report at Codecov.
|
I'm sorry, I forget a |
Head branch was pushed to by a user without write access
My bad, I think I didn't have it in my comment. |
Thanks! |
There are four macros which will generate loop whose body is not a block. The
gen_loop_issue395
andgen_A_mul_B
macro causeStackOverflowError
in current master while thegen_single_loop
andgen_nest_loop
causeLoadError: TypeError: in typeassert, expected Int64, got a value of type Static.StaticInt{1}
. I have no idea about these errors, but warp those loop body as a block that fixes all of these error.