http://277898785 fix flaky tests by properly selecting ports

Author: djherbis

test

@@ -100,7 +100,7 @@ fi
 docker run --rm -t --read-only --net=none \
     -e HOME=/tmp -e KAGGLE_DATA_PROXY_TOKEN=test-key \
     -e KAGGLE_USER_SECRETS_TOKEN_KEY=test-secrets-key \
-    -e KAGGLE_URL_BASE=http://127.0.0.1:8001 \
+    -e KAGGLE_URL_BASE=http://127.0.0.1:0 \
     -e KAGGLE_DATA_PROXY_URL=http://127.0.0.1:8000 \
     -e KAGGLE_DATA_PROXY_PROJECT=test \
     -e TF_FORCE_GPU_ALLOW_GROWTH=true \

tests/test_datasets.py

@@ -72,6 +72,8 @@ def get_response(self):
                 threading.Thread(target=httpd.serve_forever).start()
 
                 try:
+                    # Make sure this server is pointed to by clients (the port may have been dynamically chosen): 
+                    env.set(_KAGGLE_URL_BASE_ENV_VAR_NAME, "http://"+httpd.server_address[0]+":"+str(httpd.server_address[1]))
                     client_func()
                 finally:
                     httpd.shutdown()

tests/test_user_secrets.py

@@ -66,6 +66,8 @@ def get_response(self):
                 threading.Thread(target=httpd.serve_forever).start()
 
                 try:
+                    # Make sure this server is pointed to by clients (the port may have been dynamically chosen): 
+                    env.set(_KAGGLE_URL_BASE_ENV_VAR_NAME, "http://"+httpd.server_address[0]+":"+str(httpd.server_address[1]))
                     client_func()
                 finally:
                     httpd.shutdown()

tests/test_user_session.py

@@ -55,6 +55,8 @@ def get_response(self):
                 threading.Thread(target=httpd.serve_forever).start()
 
                 try:
+                    # Make sure this server is pointed to by clients (the port may have been dynamically chosen): 
+                    env.set(_KAGGLE_URL_BASE_ENV_VAR_NAME, "http://"+httpd.server_address[0]+":"+str(httpd.server_address[1]))
                     client_func()
                 finally:
                     httpd.shutdown()