Skip to content

Commit 776a50a

Browse files
authored
Reorder FROM & ENV so that build works correctly
1 parent c8649e5 commit 776a50a

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

Dockerfile.tmpl

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,18 @@ ARG TORCHAUDIO_VERSION
88
ARG TORCHTEXT_VERSION
99
ARG TORCHVISION_VERSION
1010

11-
# Ensures shared libraries installed with conda can be found by the dynamic link loader.
12-
ENV LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/opt/conda/lib"
13-
1411
{{ if eq .Accelerator "gpu" }}
1512
FROM gcr.io/kaggle-images/python-lightgbm-whl:${GPU_BASE_IMAGE_NAME}-${BASE_IMAGE_TAG}-${LIGHTGBM_VERSION} AS lightgbm_whl
1613
FROM gcr.io/kaggle-images/python-torch-whl:${GPU_BASE_IMAGE_NAME}-${BASE_IMAGE_TAG}-${TORCH_VERSION} AS torch_whl
1714
FROM ${BASE_IMAGE_REPO}/${GPU_BASE_IMAGE_NAME}:${BASE_IMAGE_TAG}
15+
{{ else }}
16+
FROM ${BASE_IMAGE_REPO}/${CPU_BASE_IMAGE_NAME}:${BASE_IMAGE_TAG}
17+
{{ end }}
18+
19+
# Ensures shared libraries installed with conda can be found by the dynamic link loader.
20+
ENV LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/opt/conda/lib"
21+
22+
{{ if eq .Accelerator "gpu" }}
1823
ARG CUDA_MAJOR_VERSION
1924
ARG CUDA_MINOR_VERSION
2025
ENV CUDA_MAJOR_VERSION=${CUDA_MAJOR_VERSION}
@@ -25,12 +30,10 @@ ENV PATH=/opt/bin:${PATH}
2530
ENV LD_LIBRARY_PATH_NO_STUBS="$LD_LIBRARY_PATH"
2631
ENV LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/usr/local/cuda/lib64/stubs"
2732
RUN ln -s /usr/local/cuda/lib64/stubs/libcuda.so /usr/local/cuda/lib64/stubs/libcuda.so.1
28-
{{ else }}
29-
FROM ${BASE_IMAGE_REPO}/${CPU_BASE_IMAGE_NAME}:${BASE_IMAGE_TAG}
3033
{{ end }}
34+
3135
# Keep these variables in sync if base image is updated.
32-
# TODO(rosbo): Still 2.9.0 rc2. Wait for the 2.9.1
33-
ENV TENSORFLOW_VERSION=2.9.0
36+
ENV TENSORFLOW_VERSION=2.9.1
3437

3538
# We need to redefine the ARG here to get the ARG value defined above the FROM instruction.
3639
# See: https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact

0 commit comments

Comments
 (0)