Skip to content

Upgrade base image to m91 #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Upgrade base image to m91 #1142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
486a21c
Upgrade base image to m91
rosbo Mar 28, 2022
9393af9
Drop ml_metrics package
rosbo Apr 5, 2022
3943a48
unpin mkl
rosbo Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Dockerfile.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ RUN conda config --add channels nvidia && \
conda config --add channels rapidsai && \
# Base image channel order: conda-forge (highest priority), defaults.
# End state: rapidsai (highest priority), nvidia, conda-forge, defaults.
# b/216162758 Pin mkl which last version breaks spacy.
conda install mkl=2021.4.0 cartopy=0.19 imagemagick=7.1 pyproj==3.1.0 && \
conda install mkl cartopy=0.19 imagemagick=7.1 pyproj==3.1.0 && \
/tmp/clean-layer.sh

{{ if eq .Accelerator "gpu" }}
Expand Down Expand Up @@ -155,7 +154,7 @@ RUN pip install pycuda && \

RUN pip install pysal && \
pip install seaborn python-dateutil dask python-igraph && \
pip install pyyaml joblib husl geopy ml_metrics mne pyshp && \
pip install pyyaml joblib husl geopy mne pyshp && \
Copy link
Contributor Author

@rosbo rosbo Apr 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping ml_metrics. This is an old package created by Ben Hamner. Last updated in 2015. Fails to install at build time now:

#17 58.62 Collecting ml_metrics
#17 58.64   Downloading ml_metrics-0.1.4.tar.gz (5.0 kB)
#17 58.65   Preparing metadata (setup.py): started
#17 59.04   Preparing metadata (setup.py): finished with status 'error'
#17 59.05   error: subprocess-exited-with-error
#17 59.05   
#17 59.05   × python setup.py egg_info did not run successfully.
#17 59.05   │ exit code: 1
#17 59.05   ╰─> [1 lines of output]
#17 59.05       error in ml_metrics setup command: use_2to3 is invalid.
#17 59.05       [end of output]
#17 59.05   
#17 59.05   note: This error originates from a subprocess, and is likely not a problem with pip.
#17 59.05 error: metadata-generation-failed
#17 59.05 
#17 59.05 × Encountered error while generating package metadata.
#17 59.05 ╰─> See above for output.

Also, it was already failing at import time.

In our Python image currently released:

import ml_metrics

Fails with:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
/tmp/ipykernel_34/1657033094.py in <module>
----> 1 import ml_metrics

/opt/conda/lib/python3.7/site-packages/ml_metrics/__init__.py in <module>
----> 1 from quadratic_weighted_kappa import *
      2 from elementwise import *
      3 from auc import auc
      4 from average_precision import apk, mapk

ModuleNotFoundError: No module named 'quadratic_weighted_kappa'

pip install pandas && \
pip install flax && \
# Install h2o from source.
Expand Down
2 changes: 1 addition & 1 deletion config.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
BASE_IMAGE_REPO=gcr.io/deeplearning-platform-release
BASE_IMAGE_TAG=m88
BASE_IMAGE_TAG=m91
CPU_BASE_IMAGE_NAME=tf2-cpu.2-6
GPU_BASE_IMAGE_NAME=tf2-gpu.2-6
LIGHTGBM_VERSION=3.3.1
Expand Down