Skip to content

Add dependencies necessary for LSP-based autocomplete. #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add dependencies necessary for LSP-based autocomplete. #1144

merged 2 commits into from
Mar 31, 2022

Conversation

jplotts
Copy link
Contributor

@jplotts jplotts commented Mar 30, 2022

b/211487924

jplotts added 2 commits March 29, 2022 09:23
@jplotts
Add jupyterlab-lsp dependency.
9aea8f6 
This is required for making LSP-based autocompletion work in the
Notebook Editor.

The tsfresh test had to be changed to single-threaded, as the
multi-threaded cleanup process was hanging trying to kill the jupyter
server that was initialized but not running.

http://b/211487924
@jplotts
Add python-lsp-server.
89c915b 
This is required for LSP-based autocomplete.

b/211487924
@jplotts jplotts requested a review from djherbis March 30, 2022 12:11
djherbis
djherbis approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It will only be available in newer images but that is usually the majority of the fleet anyway :)

@jplotts jplotts merged commit 4d79daa into main Mar 31, 2022
@jplotts jplotts deleted the add-deps branch March 31, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djherbis djherbis djherbis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplotts @djherbis