Skip to content

Pin matplolib as upgrade of seaborn has conflict #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Dockerfile.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,12 @@ RUN export PATH=/usr/local/cuda/bin:$PATH && \
/tmp/clean-layer.sh
{{ end }}

# Make sure to install at least the version 0.13.0 of seaborn
# which has a fix for heatmap (b/308525631)
# (b/308525631) Pin Matplotlib until seaborn can be upgraded
# to >0.13.0 (now it's stuck by a package conflict with ydata-profiling 4.5.1).
RUN JAXVER=$(pip freeze | grep -e "^jax==") && \
pip install \
seaborn>=0.13.0 \
pip install --upgrade \
"matplotlib<3.8.0" \
seaborn \
python-dateutil dask igraph \
pyyaml joblib husl geopy mne pyshp \
pandas \
Expand Down
2 changes: 1 addition & 1 deletion tests/test_seaborn.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class TestSeaborn(unittest.TestCase):
# Fails if seaborn gets downgraded by other package installations.
def test_version(self):
self.assertGreaterEqual(StrictVersion(sns.__version__), StrictVersion("0.9.0"))
self.assertGreaterEqual(StrictVersion(sns.__version__), StrictVersion("0.12.0"))


def test_option(self):
Expand Down