Skip to content

Add torchtune to docker image packages #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Add torchtune to docker image packages #1456

merged 2 commits into from
Dec 16, 2024

Conversation

psbang
Copy link
Contributor

@psbang psbang commented Dec 16, 2024

No description provided.

@psbang psbang requested a review from rosbo December 16, 2024 20:18
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's add @calderjo given he is the owner now.


import subprocess

class TestAlbumentations(unittest.TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename test class to TestTorchtune.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is why we get PRs reviewed 🤦🏾‍♂️

@rosbo rosbo requested a review from calderjo December 16, 2024 20:19
Copy link
Contributor

@calderjo calderjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@psbang psbang merged commit 2cb0a25 into main Dec 16, 2024
3 checks passed
@psbang psbang deleted the psbang-torchtune branch December 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants