Memory leak fix in SPIRVDecoder::getSourceContinuedInstructions (#2259)

bwlodarcz · web-flow · commit b891a51a8b02 · 2023-12-18T09:50:20.000-05:00
SPIRVEntry created in function getEntry isn't deleted when
it is ExtOp and isn't SourceContinued.
diff --git a/lib/SPIRV/libSPIRV/SPIRVStream.cpp b/lib/SPIRV/libSPIRV/SPIRVStream.cpp
@@ -357,6 +357,7 @@ std::vector<SPIRVEntry *> SPIRVDecoder::getSourceContinuedInstructions() {
     SPIRVExtInst *Inst = static_cast<SPIRVExtInst *>(Entry);
     if (Inst->getExtOp() != SPIRVDebug::Instruction::SourceContinued) {
       IS.seekg(Pos); // restore position
+      delete Entry;
       return ContinuedInst;
     }
     M.add(Entry);

Original file line number	Diff line number	Diff line change
`@@ -357,6 +357,7 @@ std::vector<SPIRVEntry *> SPIRVDecoder::getSourceContinuedInstructions() {`
`357`	`357`	`SPIRVExtInst Inst = static_cast<SPIRVExtInst >(Entry);`
`358`	`358`	`if (Inst->getExtOp() != SPIRVDebug::Instruction::SourceContinued) {`
`359`	`359`	`IS.seekg(Pos); // restore position`
	`360`	`+ delete Entry;`
`360`	`361`	`return ContinuedInst;`
`361`	`362`	`}`
`362`	`363`	`M.add(Entry);`