Skip to content

Commit ff19818

Browse files
aratajewsvenvh
authored andcommitted
Remove unncessary LLVM_FALLTHROUGH statements for empty switch cases
1 parent 9a81ba8 commit ff19818

File tree

1 file changed

+0
-45
lines changed

1 file changed

+0
-45
lines changed

lib/SPIRV/SPIRVUtil.cpp

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1631,20 +1631,16 @@ class SPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
16311631
UnmangledName = UniqUnmangledName.str();
16321632
switch (OC) {
16331633
case OpConvertUToF:
1634-
LLVM_FALLTHROUGH;
16351634
case OpUConvert:
1636-
LLVM_FALLTHROUGH;
16371635
case OpSatConvertUToS:
16381636
// Treat all arguments as unsigned
16391637
addUnsignedArg(-1);
16401638
break;
16411639
case OpSubgroupShuffleINTEL:
1642-
LLVM_FALLTHROUGH;
16431640
case OpSubgroupShuffleXorINTEL:
16441641
addUnsignedArg(1);
16451642
break;
16461643
case OpSubgroupShuffleDownINTEL:
1647-
LLVM_FALLTHROUGH;
16481644
case OpSubgroupShuffleUpINTEL:
16491645
addUnsignedArg(2);
16501646
break;
@@ -1660,32 +1656,22 @@ class SPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
16601656
addUnsignedArg(0);
16611657
break;
16621658
case OpAtomicUMax:
1663-
LLVM_FALLTHROUGH;
16641659
case OpAtomicUMin:
16651660
addUnsignedArg(0);
16661661
addUnsignedArg(3);
16671662
break;
16681663
case OpGroupUMax:
1669-
LLVM_FALLTHROUGH;
16701664
case OpGroupUMin:
1671-
LLVM_FALLTHROUGH;
16721665
case OpGroupNonUniformBroadcast:
1673-
LLVM_FALLTHROUGH;
16741666
case OpGroupNonUniformBallotBitCount:
1675-
LLVM_FALLTHROUGH;
16761667
case OpGroupNonUniformShuffle:
1677-
LLVM_FALLTHROUGH;
16781668
case OpGroupNonUniformShuffleXor:
1679-
LLVM_FALLTHROUGH;
16801669
case OpGroupNonUniformShuffleUp:
1681-
LLVM_FALLTHROUGH;
16821670
case OpGroupNonUniformShuffleDown:
16831671
addUnsignedArg(2);
16841672
break;
16851673
case OpGroupNonUniformInverseBallot:
1686-
LLVM_FALLTHROUGH;
16871674
case OpGroupNonUniformBallotFindLSB:
1688-
LLVM_FALLTHROUGH;
16891675
case OpGroupNonUniformBallotFindMSB:
16901676
addUnsignedArg(1);
16911677
break;
@@ -1694,36 +1680,22 @@ class SPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
16941680
addUnsignedArg(2);
16951681
break;
16961682
case OpGroupNonUniformIAdd:
1697-
LLVM_FALLTHROUGH;
16981683
case OpGroupNonUniformFAdd:
1699-
LLVM_FALLTHROUGH;
17001684
case OpGroupNonUniformIMul:
1701-
LLVM_FALLTHROUGH;
17021685
case OpGroupNonUniformFMul:
1703-
LLVM_FALLTHROUGH;
17041686
case OpGroupNonUniformSMin:
1705-
LLVM_FALLTHROUGH;
17061687
case OpGroupNonUniformFMin:
1707-
LLVM_FALLTHROUGH;
17081688
case OpGroupNonUniformSMax:
1709-
LLVM_FALLTHROUGH;
17101689
case OpGroupNonUniformFMax:
1711-
LLVM_FALLTHROUGH;
17121690
case OpGroupNonUniformBitwiseAnd:
1713-
LLVM_FALLTHROUGH;
17141691
case OpGroupNonUniformBitwiseOr:
1715-
LLVM_FALLTHROUGH;
17161692
case OpGroupNonUniformBitwiseXor:
1717-
LLVM_FALLTHROUGH;
17181693
case OpGroupNonUniformLogicalAnd:
1719-
LLVM_FALLTHROUGH;
17201694
case OpGroupNonUniformLogicalOr:
1721-
LLVM_FALLTHROUGH;
17221695
case OpGroupNonUniformLogicalXor:
17231696
addUnsignedArg(3);
17241697
break;
17251698
case OpGroupNonUniformUMax:
1726-
LLVM_FALLTHROUGH;
17271699
case OpGroupNonUniformUMin:
17281700
addUnsignedArg(2);
17291701
addUnsignedArg(3);
@@ -1753,11 +1725,8 @@ class OpenCLStdToSPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
17531725
bool needRetTypePostfix() {
17541726
switch (ExtOpId) {
17551727
case OpenCLLIB::Vload_half:
1756-
LLVM_FALLTHROUGH;
17571728
case OpenCLLIB::Vload_halfn:
1758-
LLVM_FALLTHROUGH;
17591729
case OpenCLLIB::Vloada_halfn:
1760-
LLVM_FALLTHROUGH;
17611730
case OpenCLLIB::Vloadn:
17621731
return true;
17631732
default:
@@ -1768,33 +1737,19 @@ class OpenCLStdToSPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
17681737
void init(StringRef) override {
17691738
switch (ExtOpId) {
17701739
case OpenCLLIB::UAbs:
1771-
LLVM_FALLTHROUGH;
17721740
case OpenCLLIB::UAbs_diff:
1773-
LLVM_FALLTHROUGH;
17741741
case OpenCLLIB::UAdd_sat:
1775-
LLVM_FALLTHROUGH;
17761742
case OpenCLLIB::UHadd:
1777-
LLVM_FALLTHROUGH;
17781743
case OpenCLLIB::URhadd:
1779-
LLVM_FALLTHROUGH;
17801744
case OpenCLLIB::UClamp:
1781-
LLVM_FALLTHROUGH;
17821745
case OpenCLLIB::UMad_hi:
1783-
LLVM_FALLTHROUGH;
17841746
case OpenCLLIB::UMad_sat:
1785-
LLVM_FALLTHROUGH;
17861747
case OpenCLLIB::UMax:
1787-
LLVM_FALLTHROUGH;
17881748
case OpenCLLIB::UMin:
1789-
LLVM_FALLTHROUGH;
17901749
case OpenCLLIB::UMul_hi:
1791-
LLVM_FALLTHROUGH;
17921750
case OpenCLLIB::USub_sat:
1793-
LLVM_FALLTHROUGH;
17941751
case OpenCLLIB::U_Upsample:
1795-
LLVM_FALLTHROUGH;
17961752
case OpenCLLIB::UMad24:
1797-
LLVM_FALLTHROUGH;
17981753
case OpenCLLIB::UMul24:
17991754
// Treat all arguments as unsigned
18001755
addUnsignedArg(-1);

0 commit comments

Comments
 (0)