Skip to content

Commit 21d93ad

Browse files
authored
Merge pull request #764 from acrobat/set-correct-property-and-return-types
Set correct property and return types
2 parents c842fcc + a7d1295 commit 21d93ad

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

lib/Github/Api/Issue/Labels.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public function replace($username, $repository, $issue, array $params)
167167
* @param string $issue
168168
* @param string $label
169169
*
170-
* @return null
170+
* @return array|string
171171
*/
172172
public function remove($username, $repository, $issue, $label)
173173
{
@@ -183,7 +183,7 @@ public function remove($username, $repository, $issue, $label)
183183
* @param string $repository
184184
* @param string $issue
185185
*
186-
* @return null
186+
* @return array|string
187187
*/
188188
public function clear($username, $repository, $issue)
189189
{

lib/Github/Api/Issue/Milestones.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public function update($username, $repository, $id, array $params)
114114
* @param string $repository
115115
* @param int $id
116116
*
117-
* @return null
117+
* @return array|string
118118
*/
119119
public function remove($username, $repository, $id)
120120
{

lib/Github/Api/Organization/Hooks.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public function update($organization, $id, array $params)
8787
* @param string $organization
8888
* @param int $id
8989
*
90-
* @return null
90+
* @return array|string
9191
*/
9292
public function ping($organization, $id)
9393
{
@@ -102,7 +102,7 @@ public function ping($organization, $id)
102102
* @param string $organization
103103
* @param int $id
104104
*
105-
* @return null
105+
* @return array|string
106106
*/
107107
public function remove($organization, $id)
108108
{

lib/Github/HttpClient/Builder.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
use Http\Discovery\HttpClientDiscovery;
1111
use Http\Discovery\MessageFactoryDiscovery;
1212
use Http\Discovery\StreamFactoryDiscovery;
13-
use Http\Message\MessageFactory;
1413
use Http\Message\RequestFactory;
1514
use Http\Message\StreamFactory;
1615
use Psr\Cache\CacheItemPoolInterface;
@@ -38,7 +37,7 @@ class Builder
3837
private $pluginClient;
3938

4039
/**
41-
* @var MessageFactory
40+
* @var RequestFactory
4241
*/
4342
private $requestFactory;
4443

@@ -62,7 +61,7 @@ class Builder
6261
/**
6362
* This plugin is special treated because it has to be the very last plugin.
6463
*
65-
* @var Plugin\CachePlugin
64+
* @var Plugin\CachePlugin|null
6665
*/
6766
private $cachePlugin;
6867

lib/Github/HttpClient/Message/ResponseMediator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public static function getContent(ResponseInterface $response)
2828
/**
2929
* @param ResponseInterface $response
3030
*
31-
* @return array|null
31+
* @return array|void
3232
*/
3333
public static function getPagination(ResponseInterface $response)
3434
{

0 commit comments

Comments
 (0)