Skip to content

Added missing docs for currentuser public keys #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Dec 4, 2016

The missing docs came to my attention in issue #467

A questions for another pr, should we rename the current user DeployKeys class (and docs files) to publickeys as this would reflect the names of github?

"Fixes" issues: #464, #467

This was referenced Dec 4, 2016
@cursedcoder
Copy link
Contributor

Merge issue now

@acrobat acrobat force-pushed the user-publickeys-docs branch from bc4dcfb to 789fe80 Compare December 6, 2016 09:19
@acrobat
Copy link
Collaborator Author

acrobat commented Dec 6, 2016

@cursedcoder rebased!

@cursedcoder cursedcoder merged commit 5a55b02 into KnpLabs:master Dec 6, 2016
@acrobat acrobat deleted the user-publickeys-docs branch December 6, 2016 09:24
@acrobat
Copy link
Collaborator Author

acrobat commented Dec 6, 2016

@cursedcoder issue #464 can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants