Skip to content

add basic branch protection docs #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Conversation

bobeagan
Copy link
Contributor

Sorry, I noticed that the Protection API did not have any docs for it and tried getting this into the other PR but you were too quick for me. I tried following similar patterns on this so let me know if anything needs changed.

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will tag a new release later tonight.

> Requires [authentication](../security.md).

```php
$protection = $client->api('repo')->protection()->show('twbs', 'bootstrap', 'master', $params);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you define the $param with something simple?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nyholm Nyholm merged commit 6a211e1 into KnpLabs:master Apr 18, 2017
@bobeagan bobeagan deleted the protection-docs branch April 18, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants