Allow unspecified event when creating review
#723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for `event` in "Create a pull request review" states that "By leaving this blank, you set the review action state to `PENDING`, which means you will need to submit the pull request review when you are ready." This means that omitting `event` is perfectly legal.
Since we now allow `event` to be missing, adjust the test case to expect POST request to be made.
acrobat
approved these changes
Aug 4, 2018
|
Thanks @mikedld! And congrats on your first contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for
eventin "Create a pull request review" states that "By leaving this blank, you set the review action state toPENDING, which means you will need to submit the pull request review when you are ready." This means that omittingeventis perfectly legal.