Skip to content

Set correct property and return types #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Set correct property and return types #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Github/Api/Issue/Labels.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public function replace($username, $repository, $issue, array $params)
* @param string $issue
* @param string $label
*
* @return null
* @return array|string
*/
public function remove($username, $repository, $issue, $label)
{
Expand All @@ -183,7 +183,7 @@ public function remove($username, $repository, $issue, $label)
* @param string $repository
* @param string $issue
*
* @return null
* @return array|string
*/
public function clear($username, $repository, $issue)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/Github/Api/Issue/Milestones.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public function update($username, $repository, $id, array $params)
* @param string $repository
* @param int $id
*
* @return null
* @return array|string
*/
public function remove($username, $repository, $id)
{
Expand Down
4 changes: 2 additions & 2 deletions lib/Github/Api/Organization/Hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function update($organization, $id, array $params)
* @param string $organization
* @param int $id
*
* @return null
* @return array|string
*/
public function ping($organization, $id)
{
Expand All @@ -102,7 +102,7 @@ public function ping($organization, $id)
* @param string $organization
* @param int $id
*
* @return null
* @return array|string
*/
public function remove($organization, $id)
{
Expand Down
5 changes: 2 additions & 3 deletions lib/Github/HttpClient/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Discovery\StreamFactoryDiscovery;
use Http\Message\MessageFactory;
use Http\Message\RequestFactory;
use Http\Message\StreamFactory;
use Psr\Cache\CacheItemPoolInterface;
Expand Down Expand Up @@ -38,7 +37,7 @@ class Builder
private $pluginClient;

/**
* @var MessageFactory
* @var RequestFactory
*/
private $requestFactory;

Expand All @@ -62,7 +61,7 @@ class Builder
/**
* This plugin is special treated because it has to be the very last plugin.
*
* @var Plugin\CachePlugin
* @var Plugin\CachePlugin|null
*/
private $cachePlugin;

Expand Down
2 changes: 1 addition & 1 deletion lib/Github/HttpClient/Message/ResponseMediator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public static function getContent(ResponseInterface $response)
/**
* @param ResponseInterface $response
*
* @return array|null
* @return array|void
*/
public static function getPagination(ResponseInterface $response)
{
Expand Down