Cleanup

Author: fzhinkin

core/apple/src/files/FileSystemApple.kt

@@ -26,21 +26,20 @@ internal actual val SystemTemporaryDirectoryImpl: Path
 
 internal actual fun dirnameImpl(path: String): String {
     memScoped {
-        return dirname(path.cstr.getPointer(this))?.toKString() ?: ""
+        return dirname(path.cstr.ptr)?.toKString() ?: ""
     }
 }
 
 internal actual fun basenameImpl(path: String): String {
     memScoped {
-        return basename(path.cstr.getPointer(this))?.toKString() ?: ""
+        return basename(path.cstr.ptr)?.toKString() ?: ""
     }
 }
 
 internal actual fun isAbsoluteImpl(path: String): Boolean = path.startsWith('/')
 
 internal actual fun mkdirImpl(path: String) {
-    val mode: UShort = 511u
-    if (mkdir(path, mode) != 0) {
+    if (mkdir(path, PermissionAllowAll) != 0) {
         throw IOException("mkdir failed: ${strerror(errno)?.toKString()}")
     }
 }

core/linux/src/files/FileSystemLinux.kt

@@ -15,14 +15,14 @@ import platform.posix.dirname
 @OptIn(ExperimentalForeignApi::class)
 internal actual fun dirnameImpl(path: String): String {
     memScoped {
-        return dirname(path.cstr.getPointer(this))?.toKString() ?: ""
+        return dirname(path.cstr.ptr)?.toKString() ?: ""
     }
 }
 
 @OptIn(ExperimentalForeignApi::class)
 internal actual fun basenameImpl(path: String): String {
     memScoped {
-        return __xpg_basename(path.cstr.getPointer(this))?.toKString() ?: ""
+        return __xpg_basename(path.cstr.ptr)?.toKString() ?: ""
     }
 }
 

core/mingw/src/files/FileSystemMingw.kt

@@ -24,13 +24,13 @@ internal actual fun atomicMoveImpl(source: Path, destination: Path) {
 
 internal actual fun dirnameImpl(path: String): String {
     memScoped {
-        return dirname(path.cstr.getPointer(this))?.toKString() ?: ""
+        return dirname(path.cstr.ptr)?.toKString() ?: ""
     }
 }
 
 internal actual fun basenameImpl(path: String): String {
     memScoped {
-        return basename(path.cstr.getPointer(this))?.toKString() ?: ""
+        return basename(path.cstr.ptr)?.toKString() ?: ""
     }
 }
 

core/native/src/files/FileSystemNative.kt

@@ -81,3 +81,6 @@ internal expect fun mkdirImpl(path: String)
 public actual open class FileNotFoundException actual constructor(
     message: String?
 ) : IOException(message)
+
+// 777 in octal, rwx for all (owner, group and others).
+internal const val PermissionAllowAll: UShort = 511u

core/unix/src/files/FileSystemUnix.kt

@@ -24,8 +24,7 @@ internal actual fun atomicMoveImpl(source: Path, destination: Path) {
 }
 
 internal actual fun mkdirImpl(path: String) {
-    val mode: UShort = 511u
-    if (mkdir(path, mode.convert()) != 0) {
+    if (mkdir(path, PermissionAllowAll.convert()) != 0) {
         throw IOException("mkdir failed: ${strerror(errno)?.toKString()}")
     }
 }