Make Path.source/sink regular functions, not expects.

Author: fzhinkin

core/api/kotlinx-io-core.api

@@ -246,5 +246,7 @@ public final class kotlinx/io/files/PathsJvmKt {
 public final class kotlinx/io/files/PathsKt {
 	public static final fun Path (Ljava/lang/String;[Ljava/lang/String;)Lkotlinx/io/files/Path;
 	public static final fun Path (Lkotlinx/io/files/Path;[Ljava/lang/String;)Lkotlinx/io/files/Path;
+	public static final fun sinkDeprecated (Lkotlinx/io/files/Path;)Lkotlinx/io/Sink;
+	public static final fun sourceDeprecated (Lkotlinx/io/files/Path;)Lkotlinx/io/Source;
 }
 

core/apple/test/NSInputStreamSourceTest.kt

@@ -7,7 +7,6 @@ package kotlinx.io
 
 import kotlinx.io.files.FileSystem
 import kotlinx.io.files.Path
-import kotlinx.io.files.sink
 import platform.Foundation.NSInputStream
 import platform.Foundation.NSURL
 import kotlin.test.Test
@@ -29,7 +28,7 @@ class NSInputStreamSourceTest {
     fun nsInputStreamSourceFromFile() {
         val file = tempFileName()
         try {
-            Path(file).sink().buffered().use {
+            FileSystem.System.sink(Path(file)).buffered().use {
                 it.writeString("example")
             }
 

core/common/src/files/Paths.kt

@@ -5,10 +5,8 @@
 
 package kotlinx.io.files
 
-import kotlinx.io.RawSink
-import kotlinx.io.RawSource
-import kotlinx.io.Sink
-import kotlinx.io.Source
+import kotlinx.io.*
+import kotlin.jvm.JvmName
 
 /**
  * A wrapper around a string representing a file path allowing to read from and write to a
@@ -105,7 +103,8 @@ public fun Path(base: Path, vararg parts: String): Path {
     ),
     level = DeprecationLevel.WARNING
 )
-public expect fun Path.source(): Source
+@JvmName("sourceDeprecated")
+public fun Path.source(): Source = FileSystem.System.source(this).buffered()
 
 /**
  * Returns [RawSink] for the given path, creates file if it doesn't exist, throws if it's a directory,
@@ -119,4 +118,5 @@ public expect fun Path.source(): Source
     ),
     level = DeprecationLevel.WARNING
 )
-public expect fun Path.sink(): Sink
+@JvmName("sinkDeprecated")
+public fun Path.sink(): Sink = FileSystem.System.sink(this).buffered()

core/js/src/files/PathsJs.kt

@@ -90,10 +90,6 @@ public actual fun Path(path: String): Path {
     return Path(path, null)
 }
 
-public actual fun Path.source(): Source = FileSystem.System.source(this).buffered()
-
-public actual fun Path.sink(): Sink = FileSystem.System.sink(this).buffered()
-
 internal class FileSource(private val path: Path) : RawSource {
     private var buffer: dynamic = null
     private var closed = false

core/jvm/src/files/PathsJvm.kt

@@ -42,6 +42,14 @@ public actual class Path internal constructor(internal val file: File) {
 
 public actual fun Path(path: String): Path = Path(File(path))
 
-public actual fun Path.source(): Source = FileSystem.System.source(this).buffered()
-
-public actual fun Path.sink(): Sink = FileSystem.System.sink(this).buffered()
+// Function only exists to provide binary compatibility with the earlier releases
+@JvmName("source")
+@PublishedApi
+@Suppress("UNUSED")
+internal fun Path.sourceHack(): Source = FileSystem.System.source(this).buffered()
+
+// Function only exists to provide binary compatibility with the earlier releases
+@JvmName("sink")
+@PublishedApi
+@Suppress("UNUSED")
+internal fun Path.sinkHack(): Sink = FileSystem.System.sink(this).buffered()

core/native/src/files/PathsNative.kt

@@ -65,10 +65,6 @@ internal expect fun isAbsoluteImpl(path: String): Boolean
 
 public actual fun Path(path: String): Path = Path(path, null)
 
-public actual fun Path.source(): Source = FileSystem.System.source(this).buffered()
-
-public actual fun Path.sink(): Sink = FileSystem.System.sink(this).buffered()
-
 internal class FileSource(
     private val file: CPointer<FILE>
 ) : RawSource {

core/wasm/src/files/PathsWasm.kt

@@ -5,9 +5,6 @@
 
 package kotlinx.io.files
 
-import kotlinx.io.Sink
-import kotlinx.io.Source
-
 public actual class Path private constructor() {
     actual override fun toString(): String = unsupported()
 
@@ -28,8 +25,3 @@ public actual class Path private constructor() {
 }
 
 public actual fun Path(path: String): Path = unsupported()
-
-
-public actual fun Path.source(): Source = unsupported()
-
-public actual fun Path.sink(): Sink = unsupported()