Move Windows-specific test to a common source set to reuse it for JVM and JS

Author: fzhinkin

core/mingw/test/files/SmokeFileTestWindows.kt renamed to core/common/test/files/SmokeFileTestWindows.kt

@@ -1,15 +1,17 @@
 /*
- * Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Copyright 2010-2024 JetBrains s.r.o. and Kotlin Programming Language contributors.
  * Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE.txt file.
  */
 
 package kotlinx.io.files
 
+import kotlinx.io.isWindows
 import kotlin.test.*
 
 class SmokeFileTestWindows {
     @Test
     fun isAbsolute() {
+        if (!isWindows) return
         assertTrue(Path("C:\\").isAbsolute)
         assertTrue(Path("C:/").isAbsolute)
         assertTrue(Path("C:/../").isAbsolute)
@@ -21,6 +23,7 @@ class SmokeFileTestWindows {
 
     @Test
     fun getParent() {
+        if (!isWindows) return
         assertNull(Path("C:\\").parent)
         assertNull(Path("a\\b").parent?.parent)
         assertEquals(Path("\\\\server"), Path("\\\\server\\share").parent)
@@ -30,6 +33,7 @@ class SmokeFileTestWindows {
 
     @Test
     fun trailingSeparatorsTrimming() {
+        if (!isWindows) return
         assertEquals(".", Path(".\\").toString())
         assertEquals("C:\\", Path("C:\\").toString())
         assertEquals("C:\\", Path("C:\\\\").toString())

core/common/test/util.kt

@@ -71,3 +71,5 @@ fun Char.repeat(count: Int): String {
 fun assertArrayEquals(a: ByteArray, b: ByteArray) {
     assertEquals(a.contentToString(), b.contentToString())
 }
+
+expect val isWindows: Boolean

core/js/src/-PlatfromJs.kt

@@ -21,3 +21,5 @@ public actual open class IOException actual constructor(
 public actual open class EOFException actual constructor(message: String?) : IOException(message) {
     public actual constructor() : this(null)
 }
+
+internal val isWindows_ = os.platform() == "win32"

core/js/src/files/FileSystemJs.kt

@@ -5,9 +5,10 @@
 
 package kotlinx.io.files
 
-import kotlinx.io.IOException
-import kotlinx.io.RawSink
-import kotlinx.io.RawSource
+import kotlinx.io.*
+import kotlinx.io.buffer
+import kotlinx.io.fs
+import kotlinx.io.os
 
 public actual val SystemFileSystem: FileSystem = object : SystemFileSystemImpl() {
     override fun exists(path: Path): Boolean {

core/js/src/files/PathsJs.kt

@@ -17,7 +17,7 @@ public actual class Path internal constructor(
         get() {
             check(pathLib !== null) { "Path module not found" }
             if (path.isEmpty()) return null
-            if (isWindows) {
+            if (isWindows_) {
                 if (!path.contains(UnixPathSeparator) && !path.contains(WindowsPathSeparator)) {
                     return null
                 }
@@ -74,8 +74,6 @@ public actual val SystemPathSeparator: Char by lazy {
 
 private const val WindowsPathSeparator: Char = '\\'
 private const val UnixPathSeparator: Char = '/'
-private val isWindows = os.platform() == "win32"
-
 public actual fun Path(path: String): Path {
     return Path(path, null)
 }
@@ -164,7 +162,7 @@ private fun isUnc(path: String): Boolean {
 }
 
 internal fun removeTrailingSeparators(path: String): String {
-    if (isWindows) {
+    if (isWindows_) {
         // don't trim the path separator right after the drive name
         val limit = if (path.length > 1) {
             if (path[1] == ':') {

core/js/src/files/imports.kt renamed to core/js/src/imports.kt

@@ -3,7 +3,7 @@
  * Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE.txt file.
  */
 
-package kotlinx.io.files
+package kotlinx.io
 
 internal val os: dynamic
     get(): dynamic {

core/js/test/utils.kt

@@ -47,3 +47,5 @@ actual fun tempFileName(): String {
         return fullpath
     }
 }
+
+actual val isWindows: Boolean = isWindows_

core/jvm/test/utilJVM.kt

@@ -24,3 +24,5 @@ actual fun tempFileName(): String {
 fun assertByteArrayEquals(expectedUtf8: String, b: ByteArray) {
     assertEquals(expectedUtf8, b.toString(Charsets.UTF_8))
 }
+
+actual val isWindows: Boolean = System.getProperty("os.name")?.startsWith("Windows") ?: false

core/native/test/util.kt

@@ -11,6 +11,7 @@ import kotlinx.cinterop.UnsafeNumber
 import kotlinx.io.files.SystemTemporaryDirectory
 import platform.posix.F_OK
 import platform.posix.access
+import kotlin.experimental.ExperimentalNativeApi
 import kotlin.random.Random
 
 @OptIn(UnsafeNumber::class, ExperimentalStdlibApi::class)
@@ -25,3 +26,6 @@ actual fun tempFileName(): String {
     }
     throw IOException("Failed to generate temp file name")
 }
+
+@OptIn(ExperimentalNativeApi::class)
+actual val isWindows: Boolean = Platform.osFamily == OsFamily.WINDOWS

core/wasm/test/utils.kt

@@ -8,3 +8,5 @@ package kotlinx.io
 import kotlinx.io.files.unsupported
 
 actual fun tempFileName(): String = unsupported()
+
+actual val isWindows: Boolean = false