Cleanup

Author: fzhinkin

core/common/src/files/FileSystem.kt

@@ -181,3 +181,6 @@ public class FileMetadata(
  * Signals an I/O operation's failure due to a missing file or directory.
  */
 public expect class FileNotFoundException(message: String?) : IOException
+
+internal const val WindowsPathSeparator: Char = '\\'
+internal const val UnixPathSeparator: Char = '/'

core/js/src/files/PathsJs.kt

@@ -72,8 +72,6 @@ public actual val SystemPathSeparator: Char by lazy {
     sep[0]
 }
 
-private const val WindowsPathSeparator: Char = '\\'
-private const val UnixPathSeparator: Char = '/'
 public actual fun Path(path: String): Path {
     return Path(path, null)
 }

core/js/test/files/SmokeFileTestWindowsJS.kt

@@ -10,7 +10,7 @@ import kotlin.test.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertNull
 
-class SmokeFileTestWindowMinGW  {
+class SmokeFileTestWindowJS  {
     @Test
     fun uncParent() {
         if (!isWindows) return

core/mingw/src/files/FileSystemMingw.kt

@@ -12,8 +12,6 @@ import kotlinx.io.IOException
 import platform.posix.*
 import platform.windows.*
 
-private const val WindowsPathSeparator: Char = '\\'
-
 internal actual fun atomicMoveImpl(source: Path, destination: Path) {
     if (MoveFileExA(source.path, destination.path, MOVEFILE_REPLACE_EXISTING.convert()) == 0) {
         // TODO: get formatted error message
@@ -22,7 +20,7 @@ internal actual fun atomicMoveImpl(source: Path, destination: Path) {
 }
 
 internal actual fun dirnameImpl(path: String): String {
-    if (!path.contains(SystemPathSeparator) && !path.contains(WindowsPathSeparator)) {
+    if (!path.contains(UnixPathSeparator) && !path.contains(WindowsPathSeparator)) {
         return ""
     }
     memScoped {
@@ -39,7 +37,7 @@ internal actual fun basenameImpl(path: String): String {
 internal actual fun isAbsoluteImpl(path: String): Boolean {
     if (path.startsWith(SystemPathSeparator)) return true
     if (path.length > 1 && path[1] == ':') {
-        if (path.length == 1) return false
+        if (path.length == 2) return false
         val next = path[2]
         return next == WindowsPathSeparator || next == SystemPathSeparator
     }

core/native/src/files/PathsNative.kt

@@ -54,7 +54,7 @@ public actual class Path internal constructor(
         }
 }
 
-public actual val SystemPathSeparator: Char = '/'
+public actual val SystemPathSeparator: Char = UnixPathSeparator
 
 internal expect fun dirnameImpl(path: String): String