AMEND

igoriakovlev · igoriakovlev · commit 7eb99f7293d3 · 2023-09-14T19:49:34.000+02:00
diff --git a/build.gradle b/build.gradle
@@ -376,7 +376,9 @@ if (CacheRedirector.enabled) {
     }
 }
 
-// Update node version to support latest wasm engine
+// Drop this configuration when the Node.JS version in KGP is at least 20.2.0
+// check it here:
+// https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/js/nodejs/NodeJsRootExtension.kt
 extensions.findByType(org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension.class).with {
     it.nodeVersion = "20.2.0"
 }
diff --git a/integration-testing/smokeTest/build.gradle b/integration-testing/smokeTest/build.gradle
@@ -60,7 +60,9 @@ kotlin {
     }
 }
 
-// Update node version to support latest wasm engine
+// Drop this configuration when the Node.JS version in KGP is at least 20.2.0
+// check it here:
+// https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/js/nodejs/NodeJsRootExtension.kt
 rootProject.extensions.findByType(org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension.class).with {
     it.nodeVersion = "20.2.0"
 }

Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,9 @@ if (CacheRedirector.enabled) {`
`376`	`376`	`}`
`377`	`377`	`}`
`378`	`378`
`379`		`-// Update node version to support latest wasm engine`
	`379`	`+// Drop this configuration when the Node.JS version in KGP is at least 20.2.0`
	`380`	`+// check it here:`
	`381`	`+// https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/js/nodejs/NodeJsRootExtension.kt`
`380`	`382`	`extensions.findByType(org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension.class).with {`
`381`	`383`	`it.nodeVersion = "20.2.0"`
`382`	`384`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,9 @@ kotlin {`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`
`63`		`-// Update node version to support latest wasm engine`
	`63`	`+// Drop this configuration when the Node.JS version in KGP is at least 20.2.0`
	`64`	`+// check it here:`
	`65`	`+// https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/js/nodejs/NodeJsRootExtension.kt`
`64`	`66`	`rootProject.extensions.findByType(org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension.class).with {`
`65`	`67`	`it.nodeVersion = "20.2.0"`
`66`	`68`	`}`