Skip to content

Commit d03f550

Browse files
committed
AMMEND CODEREVIEW FIXES
1 parent c828764 commit d03f550

File tree

5 files changed

+17
-25
lines changed

5 files changed

+17
-25
lines changed

build.gradle

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ buildscript {
5555
maven { url "https://plugins.gradle.org/m2/" }
5656
CommunityProjectsBuild.addDevRepositoryIfEnabled(delegate, project)
5757
mavenLocal()
58+
// This is bootstrap wasm repo, remove it as regular atomic-fu will be published
59+
maven { url "https://maven.pkg.jetbrains.space/kotlin/p/wasm/experimental" }
5860
}
5961

6062
dependencies {
@@ -140,6 +142,8 @@ allprojects {
140142
google()
141143
mavenCentral()
142144
CommunityProjectsBuild.addDevRepositoryIfEnabled(delegate, project)
145+
// This is bootstrap wasm repo, remove it as regular atomic-fu will be published
146+
maven { url "https://maven.pkg.jetbrains.space/kotlin/p/wasm/experimental" }
143147
}
144148
}
145149

@@ -161,6 +165,7 @@ configure(subprojects.findAll { !sourceless.contains(it.name) && it.name != core
161165
apply from: rootProject.file("gradle/compile-js-multiplatform.gradle")
162166

163167
// TODO: Wasm target names have been changed since 1.9.20, remove this after migration to 1.9.20
168+
// https://github.com/Kotlin/kotlinx.coroutines/issues/3846
164169
def isNewWasmTargetEnabled = isKotlinVersionAtLeast(ext.kotlin_version, 1, 9, 20)
165170
if (isNewWasmTargetEnabled) {
166171
apply from: rootProject.file("gradle/compile-wasm-multiplatform.gradle")

gradle.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ kotlin_version=1.9.0
1010
# Dependencies
1111
junit_version=4.12
1212
junit5_version=5.7.0
13-
atomicfu_version=0.22.0
13+
# This is bootstrap atomicFU version with wasm support, remove it as regular atomic-fu will be published
14+
atomicfu_version=0.21.0-wasm0
1415
knit_version=0.4.0
1516
html_version=0.7.2
1617
lincheck_version=2.18.1

gradle/compile-wasm-multiplatform.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
2+
* Copyright 2016-2023 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
33
*/
44

55
kotlin {
@@ -15,13 +15,13 @@ kotlin {
1515
wasmJsMain {
1616
kotlin {
1717
srcDir 'jsWasm/src'
18-
srcDir 'wasm/src'
18+
srcDir 'wasmJs/src'
1919
}
2020
}
2121
wasmJsTest {
2222
kotlin {
2323
srcDir 'jsWasm/test'
24-
srcDir 'wasm/test'
24+
srcDir 'wasmJs/test'
2525
}
2626
}
2727
wasmJsTest.dependencies {

gradle/compile-wasm-multiplatform19.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
2+
* Copyright 2016-2023 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
33
*/
44

55
kotlin {
@@ -15,13 +15,13 @@ kotlin {
1515
wasmMain {
1616
kotlin {
1717
srcDir 'jsWasm/src'
18-
srcDir 'wasm/src'
18+
srcDir 'wasmJs/src'
1919
}
2020
}
2121
wasmTest {
2222
kotlin {
2323
srcDir 'jsWasm/test'
24-
srcDir 'wasm/test'
24+
srcDir 'wasmJs/test'
2525
}
2626
}
2727
wasmTest.dependencies {

kotlinx-coroutines-core/build.gradle

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ if (rootProject.ext.native_targets_enabled) {
2121
apply from: rootProject.file("gradle/compile-js-multiplatform.gradle")
2222

2323
// TODO: Wasm target names have been changed since 1.9.20, remove this after migration to 1.9.20
24+
// https://github.com/Kotlin/kotlinx.coroutines/issues/3846
2425
def isNewWasmTargetEnabled = isKotlinVersionAtLeast(ext.kotlin_version, 1, 9, 20)
2526
if (isNewWasmTargetEnabled) {
2627
apply from: rootProject.file("gradle/compile-wasm-multiplatform.gradle")
@@ -35,7 +36,9 @@ apply from: rootProject.file('gradle/publish.gradle')
3536
3637
TARGETS SOURCE SETS
3738
------- ----------------------------------------------
38-
39+
wasmJs -------------------------------------------------+
40+
|
41+
|
3942
js -----------------------------------------------------+
4043
|
4144
V
@@ -276,23 +279,6 @@ jvmTest {
276279
// Setup manifest for kotlinx-coroutines-core-jvm.jar
277280
jvmJar { setupManifest(it) }
278281

279-
void addIngoreTestsForWasm(org.gradle.api.tasks.testing.TestFilter filter) {
280-
filter.excludeTest("ChannelsTest", "testIterableAsReceiveChannel")
281-
filter.excludeTest("ChannelsTest", "testEmptyList")
282-
filter.excludeTest("ChannelsTest", "testToList")
283-
filter.excludeTest("ChannelBuildersFlowTest", "testConsumeAsFlowProduceBuffered")
284-
}
285-
286-
if (isNewWasmTargetEnabled) {
287-
wasmJsNodeTest {
288-
addIngoreTestsForWasm(filter)
289-
}
290-
} else {
291-
wasmNodeTest {
292-
addIngoreTestsForWasm(filter)
293-
}
294-
}
295-
296282
/*
297283
* Setup manifest for kotlinx-coroutines-core.jar
298284
* This is convenient for users that pass -javaagent arg manually and also is a workaround #2619 and KTIJ-5659.

0 commit comments

Comments
 (0)