Skip to content

Commit 89f2014

Browse files
aeubanksanton-bannykh
authored andcommitted
[NFC][CGSCC] Remove RCWorklist from CGSCCUpdateResult (llvm#95448)
After llvm#94815, this is only used within ModuleToPostOrderCGSCCPassAdaptor::run(), so keep it local to that function. (cherry picked from commit b312cbf)
1 parent 6f14f2e commit 89f2014

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

llvm/include/llvm/Analysis/CGSCCPassManager.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -230,17 +230,6 @@ using ModuleAnalysisManagerCGSCCProxy =
230230
/// Passes which do not change the call graph structure in any way can just
231231
/// ignore this argument to their run method.
232232
struct CGSCCUpdateResult {
233-
/// Worklist of the RefSCCs queued for processing.
234-
///
235-
/// When a pass refines the graph and creates new RefSCCs or causes them to
236-
/// have a different shape or set of component SCCs it should add the RefSCCs
237-
/// to this worklist so that we visit them in the refined form.
238-
///
239-
/// This worklist is in reverse post-order, as we pop off the back in order
240-
/// to observe RefSCCs in post-order. When adding RefSCCs, clients should add
241-
/// them in reverse post-order.
242-
SmallPriorityWorklist<LazyCallGraph::RefSCC *, 1> &RCWorklist;
243-
244233
/// Worklist of the SCCs queued for processing.
245234
///
246235
/// When a pass refines the graph and creates new SCCs or causes them to have

llvm/lib/Analysis/CGSCCPassManager.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,14 @@ ModuleToPostOrderCGSCCPassAdaptor::run(Module &M, ModuleAnalysisManager &AM) {
162162

163163
SmallVector<Function *, 4> DeadFunctions;
164164

165-
CGSCCUpdateResult UR = {
166-
RCWorklist, CWorklist, InvalidRefSCCSet,
167-
InvalidSCCSet, nullptr, PreservedAnalyses::all(),
168-
InlinedInternalEdges, DeadFunctions, {}};
165+
CGSCCUpdateResult UR = {CWorklist,
166+
InvalidRefSCCSet,
167+
InvalidSCCSet,
168+
nullptr,
169+
PreservedAnalyses::all(),
170+
InlinedInternalEdges,
171+
DeadFunctions,
172+
{}};
169173

170174
// Request PassInstrumentation from analysis manager, will use it to run
171175
// instrumenting callbacks for the passes later.

0 commit comments

Comments
 (0)