Skip to content

Commit 8b6f73b

Browse files
author
Kayla Wilkins
committed
fixing list scroll issues when search is fixed
1 parent 3ebb0b1 commit 8b6f73b

File tree

3 files changed

+25
-9
lines changed

3 files changed

+25
-9
lines changed

src/components/2_molecules/search-header.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ class SearchHeader extends React.Component {
4343
`}
4444
render={data => (
4545
<header
46-
className={`md:mb-4 searchHeader ${
47-
searchIsFixed ? "searchHeader--fixed" : ""
46+
className={`md:mb-4 search-header ${
47+
searchIsFixed ? "search-header--fixed" : ""
4848
}`}
4949
>
5050
<Search searchIndex={data.siteSearchIndex.index} />

src/components/2_molecules/search.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,30 +23,30 @@ export default class Search extends Component {
2323
onChange={this.search}
2424
placeholder="Search"
2525
/>
26-
<ul className="p-0 bg-white">
26+
<ul className="p-0 search-results-list">
2727
{this.state.results.map((n, i) => {
2828
const { query } = this.state;
2929
return (
3030
<div key={i}>
3131
{n.getSummary &&
3232
n.getSummary.toLowerCase().includes(query.toLowerCase()) && (
33-
<li className="list-reset">
33+
<li className="list-reset p-1 md:p-0">
3434
<Link to={`/api/v4/${_.kebabCase(n.name)}`}>
3535
{n.getSummary}
3636
</Link>
3737
</li>
3838
)}
3939
{n.postSummary &&
4040
n.postSummary.toLowerCase().includes(query.toLowerCase()) && (
41-
<li className="list-reset">
41+
<li className="list-reset p-1 md:p-0">
4242
<Link to={`/api/v4/${_.kebabCase(n.name)}/#post`}>
4343
{n.postSummary}
4444
</Link>
4545
</li>
4646
)}
4747
{n.putSummary &&
4848
n.putSummary.toLowerCase().includes(query.toLowerCase()) && (
49-
<li className="list-reset">
49+
<li className="list-reset p-1 md:p-0">
5050
<Link to={`/api/v4/${_.kebabCase(n.name)}/#put`}>
5151
{n.putSummary}
5252
</Link>
@@ -56,7 +56,7 @@ export default class Search extends Component {
5656
n.deleteSummary
5757
.toLowerCase()
5858
.includes(query.toLowerCase()) && (
59-
<li className="list-reset">
59+
<li className="list-reset p-1 md:p-0">
6060
<Link to={`/api/v4/${_.kebabCase(n.name)}/#delete`}>
6161
{n.deleteSummary}
6262
</Link>

src/css/components/4_pages/api-page.css

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,21 +105,32 @@
105105
@apply border-grey-light;
106106
}
107107

108-
.searchHeader {
108+
.search-header {
109109
position: relative;
110110
top: 0;
111111
width: auto;
112112
transition: all 0.15s cubic-bezier(0, 0, 0.2, 1);
113113
}
114114

115-
.searchHeader.searchHeader--fixed {
115+
.search-header.search-header--fixed {
116116
position: fixed;
117117
top: 65px;
118118
left: 0;
119119
width: 100%;
120120
z-index: 1;
121121
}
122122

123+
.search-results-list {
124+
background-color: #fff;
125+
}
126+
127+
.search-header--fixed .search-results-list {
128+
max-height: 250px;
129+
height: 100%;
130+
overflow-y: scroll;
131+
box-shadow: 0px 5px 8px -2px rgba(0, 0, 0, 0.5);
132+
}
133+
123134
@screen md {
124135
.api-content-wrapper {
125136
margin-left: 300px;
@@ -148,4 +159,9 @@
148159
width: 300px;
149160
padding: 2rem;
150161
}
162+
163+
.search-results-list {
164+
box-shadow: none;
165+
background-color: none;
166+
}
151167
}

0 commit comments

Comments
 (0)