Skip to content

Commit f9962f5

Browse files
authored
Merge pull request #182 from asad9711/MLE-10219
improve warning/error message
2 parents 6554727 + 5a9ad6d commit f9962f5

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

commands/run.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ module.exports = function (args) {
6969
//validate the config options
7070
validate(lt_config, resp)
7171
.then(function (cypressVersion) {
72-
console.log("cypressVersion requested - ", cypressVersion);
73-
7472
/*
7573
update ltconfig to contain the cypress_version
7674
case 1: user passed cypress_version in run_settings, this case will work as earlier

commands/utils/set_args.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ function sync_args_from_cmd(args) {
224224

225225
// if reporter_config_file parameter, add it in lt config alongwith a warning on console
226226
if (!lt_config["run_settings"]["reporter_config_file"]) {
227+
console.log("Warning !! Value of reporter_config_file parameter missing. Proceeding with default reporter config");
227228
lt_config["run_settings"]["reporter_config_file"] = constants.LT_BASE_REPORTER_CONFIG_FILE_NAME;
228229
}
229230

commands/utils/validate.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,12 +240,12 @@ module.exports = validate_config = function (lt_config, validation_configs) {
240240
);
241241
}else if (reporter_config.reporterEnabled && reporter_config.reporterEnabled != ""){
242242
if (!reporter_config.reporterEnabled.includes("mochawesome")){
243-
reject("Error!! Please add mochawesome in reporterEnabled and add the related config");
243+
console.log("Warning!! mochawesome reporter config not present. Command log may not be visible on dashboard");
244244
}
245245
}
246246
} catch {
247247
console.log(
248-
"reporter_config_file can not parsed, please provide a valid json in Reporter Config"
248+
"reporter_config_file could not be parsed, please provide a valid json in Reporter Config"
249249
);
250250
reject("Error!! Reporter JSON File does not have correct json");
251251
}

0 commit comments

Comments
 (0)