Fix static analysis signature issues

Author: LukeSlev

src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/ApplicationTypeVersions/NewAzServiceFabricManagedClusterApplicationTypeVersion.cs

@@ -57,7 +57,7 @@ public class NewAzServiceFabricManagedClustersApplicationTypeVersion : ManagedAp
         public string PackageUrl { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipeline = true, HelpMessage = "Specify the tags as key/value pairs.")]
-        public Hashtable Tags { get; set; }
+        public Hashtable Tag { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "Continue without prompts")]
         public SwitchParameter Force { get; set; }
@@ -87,7 +87,7 @@ public override void ExecuteCmdlet()
                             location: cluster.Location,
                             packageUrl: this.PackageUrl,
                             force: this.Force.IsPresent,
-                            tags: this.Tags);
+                            tags: this.Tag);
                         WriteObject(new PSManagedApplicationTypeVersion(managedAppTypeVersion), false);
                     }
                 }

src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/ApplicationTypeVersions/SetAzServiceFabricManagedClusterApplicationTypeVersion.cs

@@ -69,7 +69,7 @@ public class SetAzServiceFabricManagedClustersApplicationTypeVersion : ManagedAp
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ByResourceGroup, HelpMessage = "Specify the tags as key/value pairs.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ByResourceId, HelpMessage = "Specify the tags as key/value pairs.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ByInputObject, HelpMessage = "Specify the tags as key/value pairs.")]
-        public Hashtable Tags { get; set; }
+        public Hashtable Tag { get; set; }
 
         [Parameter(Mandatory = true, ParameterSetName = ByResourceId, ValueFromPipelineByPropertyName = true,
             HelpMessage = "Arm ResourceId of the managed application type version.")]
@@ -154,9 +154,9 @@ private ApplicationTypeVersionResource GetUpdatedAppTypeVersionParams(Applicatio
             {
                 currentAppTypeVersion.AppPackageUrl = this.PackageUrl;
             }
-            if (this.IsParameterBound(c => c.Tags))
+            if (this.IsParameterBound(c => c.Tag))
             {
-                currentAppTypeVersion.Tags = this.Tags?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string);
+                currentAppTypeVersion.Tags = this.Tag?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string);
             }
 
             return currentAppTypeVersion;

src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/ApplicationTypes/NewAzServiceFabricManagedClusterApplicationType.cs

@@ -46,7 +46,7 @@ public class NewAzServiceFabricManagedClusterApplicationType : ManagedApplicatio
         public string Name { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Specify the tags as key/value pairs.")]
-        public Hashtable Tags { get; set; }
+        public Hashtable Tag { get; set; }
         #endregion
 
         public override void ExecuteCmdlet()
@@ -63,7 +63,7 @@ public override void ExecuteCmdlet()
                     }
                     else
                     {
-                        var appType = CreateManagedApplicationType(this.Name, cluster.Location, this.Tags);
+                        var appType = CreateManagedApplicationType(this.Name, cluster.Location, this.Tag);
                         WriteObject(new PSManagedApplicationType(appType), false);
                     }
                 }

src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/ApplicationTypes/SetAzServiceFabricManagedClusterApplicationType.cs

@@ -53,7 +53,7 @@ public class SetAzServiceFabricManagedClusterApplicationType : ManagedApplicatio
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ByResourceGroup, HelpMessage = "Specify the tags as key/value pairs.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ByInputObject, HelpMessage = "Specify the tags as key/value pairs.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ByResourceId, HelpMessage = "Specify the tags as key/value pairs.")]
-        public Hashtable Tags { get; set; }
+        public Hashtable Tag { get; set; }
 
         [Parameter(Mandatory = true, ParameterSetName = ByResourceId, ValueFromPipelineByPropertyName = true,
             HelpMessage = "Arm ResourceId of the managed application type.")]
@@ -130,8 +130,8 @@ private ApplicationTypeResource GetUpdatedAppTypeParams(ApplicationTypeResource
             }
 
 
-            if (this.IsParameterBound(c => c.Tags)) {
-                currentAppType.Tags = this.Tags?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string);
+            if (this.IsParameterBound(c => c.Tag)) {
+                currentAppType.Tags = this.Tag?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string);
             }
 
             return currentAppType;

src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/Services/NewAzServiceFabricManagedClusterService.cs

@@ -344,7 +344,7 @@ public class NewAzServiceFabricManagedClusterService : ManagedApplicationCmdletB
         public ServicePackageActivationModeEnum ServicePackageActivationMode { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Specify the tags as key/value pairs.")]
-        public Hashtable Tags { get; set; }
+        public Hashtable Tag { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "Continue without prompts")]
         public SwitchParameter Force { get; set; }
@@ -406,7 +406,7 @@ public class NewAzServiceFabricManagedClusterService : ManagedApplicationCmdletB
             HelpMessage = "Indicates that the service uses the named partition scheme. Services using this model usually have data that can be bucketed, within a bounded set. Some common examples of data fields used as named partition keys would be regions, postal codes, customer groups, or other business boundaries.")]
         [Parameter(Mandatory = true, ParameterSetName = StatefulNamed,
             HelpMessage = "Indicates that the service uses the named partition scheme. Services using this model usually have data that can be bucketed, within a bounded set. Some common examples of data fields used as named partition keys would be regions, postal codes, customer groups, or other business boundaries.")]
-        public string[] PartitionNames { get; set; }
+        public string[] PartitionName { get; set; }
         #endregion
 
         #endregion
@@ -477,7 +477,7 @@ private ServiceResource GetNewServiceParameters(string location)
         {
             ServiceResource service = new ServiceResource()
             {
-                Tags = this.Tags?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string),
+                Tags = this.Tag?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string),
                 Location = location,
                 Properties = new ServiceResourceProperties()
             };
@@ -599,7 +599,7 @@ private Partition SetPartitionDescription()
                     return new UniformInt64RangePartitionScheme(this.PartitionCount, this.LowKey, this.HighKey);
                 case StatelessNamed:
                 case StatefulNamed:
-                    return new NamedPartitionScheme(this.PartitionNames);
+                    return new NamedPartitionScheme(this.PartitionName);
                 default:
                     throw new PSArgumentException("Invalid ParameterSetName");
             }

src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/Services/SetAzServiceFabricManagedClusterService.cs

@@ -309,7 +309,7 @@ public class SetAzServiceFabricManagedClusterService : ManagedApplicationCmdletB
         public ServicePackageActivationModeEnum ServicePackageActivationMode { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Specify the tags as key/value pairs.")]
-        public Hashtable Tags { get; set; }
+        public Hashtable Tag { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "Continue without prompts")]
         public SwitchParameter Force { get; set; }
@@ -386,9 +386,9 @@ private ServiceResource GetUpdatedServiceParams(ServiceResource inputObject = nu
 
             WriteVerbose($"Updating managed service '{this.Name}.'");
 
-            if (this.IsParameterBound(c => c.Tags))
+            if (this.IsParameterBound(c => c.Tag))
             {
-                currentService.Tags = this.Tags?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string);
+                currentService.Tags = this.Tag?.Cast<DictionaryEntry>().ToDictionary(d => d.Key as string, d => d.Value as string);
             }
             ServiceResourceProperties properties = currentService.Properties;
 

tools/StaticAnalysis/Exceptions/Az.ServiceFabric/SignatureIssues.csv

@@ -7,3 +7,5 @@
 "Microsoft.Azure.PowerShell.Cmdlets.ServiceFabric.dll","Microsoft.Azure.Commands.ServiceFabric.Commands.SetAzureRmServiceFabricSetting","Set-AzServiceFabricSetting","1","8510","Cmdlet 'Set-AzServiceFabricSetting' has multiple parameter sets, but no defined default parameter set.","Define a default parameter set in the cmdlet attribute."
 "Microsoft.Azure.PowerShell.Cmdlets.ServiceFabric.dll","Microsoft.Azure.Commands.ServiceFabric.Commands.SetAzureRmServiceFabricUpgradeType","Set-AzServiceFabricUpgradeType","1","8510","Cmdlet 'Set-AzServiceFabricUpgradeType' has multiple parameter sets, but no defined default parameter set.","Define a default parameter set in the cmdlet attribute."
 "Microsoft.Azure.PowerShell.Cmdlets.ServiceFabric.dll","Microsoft.Azure.Commands.ServiceFabric.Commands.NewAzServiceFabricService","New-AzServiceFabricService","1","8410","Parameter Stateless of cmdlet New-AzServiceFabricService does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
+"Microsoft.Azure.PowerShell.Cmdlets.ServiceFabric.dll","Microsoft.Azure.Commands.ServiceFabric.Commands.SetAzServiceFabricManagedClusterService","Set-AzServiceFabricManagedClusterService","1","8410","Parameter Stateless of cmdlet Set-AzServiceFabricManagedClusterService does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
+"Microsoft.Azure.PowerShell.Cmdlets.ServiceFabric.dll","Microsoft.Azure.Commands.ServiceFabric.Commands.NewAzServiceFabricManagedClusterService","New-AzServiceFabricManagedClusterService","1","8410","Parameter Stateless of cmdlet New-AzServiceFabricManagedClusterService does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."