Skip to content

Commit 948025f

Browse files
authored
Add feedback on the PR (Azure#14820)
1 parent 64e42f3 commit 948025f

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

tools/Az.Tools.Predictor/Az.Tools.Predictor/Az.Tools.Predictor.psd1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ PowerShellVersion = '7.2'
4343
# Modules that must be imported into the global environment prior to importing this module
4444
# RequiredModules = @(@{ModuleName="PSReadLine"; ModuleVersion="2.2.0-beta2"})
4545

46-
# NestedModules = @("Microsoft.Azure.PowerShell.Tools.AzPredictor.dll")
46+
NestedModules = @("Microsoft.Azure.PowerShell.Tools.AzPredictor.dll")
4747

4848
ScriptsToProcess = @("PromptSurvey.ps1")
4949

tools/Az.Tools.Predictor/Az.Tools.Predictor/Commands/OpenAzSurvey.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,10 @@ protected override void ProcessRecord()
4343
var profileSettings = Settings.GetProfileSettings();
4444
var surveyId = profileSettings?.SurveyId?.ToString(CultureInfo.InvariantCulture) ?? "000000";
4545

46-
var link = string.Format(OpenAzSurveyLink._SurveyLinkFormat, surveyId, CultureInfo.InvariantCulture);
46+
var link = string.Format(OpenAzSurvey._SurveyLinkFormat, surveyId, CultureInfo.InvariantCulture);
4747

48-
Console.WriteLine($"Opening survey {link}");
48+
Console.WriteLine($"Opening the default browser to {link}");
4949

50-
// TODO [mahuang] Ouput the link for user to copy/paste in case it's not open in the default browser.
5150
var processStartInfo = new ProcessStartInfo();
5251
processStartInfo.FileName = link;
5352
processStartInfo.UseShellExecute = true;

tools/Az.Tools.Predictor/Az.Tools.Predictor/InterceptSurvey.ps1

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,11 +218,10 @@ if ($shouldIntercept) {
218218
}
219219
}
220220

221-
Write-Host "---------------------------------------------------";
222-
Write-Host "Survey:" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline;
223-
Write-Host " How was your experience using Az predictor?";
224-
Write-Host "";
225-
Write-Host "Run " -NoNewline; Write-Host "Open-AzSurvey" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline; Write-Host " to give us your feedback.";
226221
Write-Host "---------------------------------------------------";
227-
222+
Write-Host "Survey:" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline;
223+
Write-Host " How was your experience using the Az Predictor module?";
224+
Write-Host "";
225+
Write-Host "Run " -NoNewline; Write-Host "Open-AzSurvey" -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline; Write-Host " to give us your feedback.";
226+
Write-Host "---------------------------------------------------";
228227
}

tools/Az.Tools.Predictor/Az.Tools.Predictor/Utilities/JsonUtilities.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ internal static class JsonUtilities
3030
/// 2. Use string instead of number for enums.
3131
/// 3. Use the string values (camel case) for enum.
3232
/// 4. Use the string values for the type <see cref="System.Version"/> in the properties and <see cref="System.Collections.Generic.IDictionary&lt;TKey, TValue>"/> keys.
33-
/// 3. Skip the property if the value is null.
33+
/// 5. Skip the property if the value is null.
3434
/// </summary>
3535
public static readonly JsonSerializerOptions DefaultSerializerOptions = new JsonSerializerOptions()
3636
{

0 commit comments

Comments
 (0)