Skip to content

Commit c7fb708

Browse files
bug fix for Get-AzKeyVaultSecret -IncludeVersions when current version is disabled (Azure#14823)
Co-authored-by: Beisi Zhou <[email protected]> Co-authored-by: Dingmeng Xue <[email protected]>
1 parent 5f9916f commit c7fb708

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/KeyVault/KeyVault/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Fixed a bug for `Get-AzKeyVaultSecret -IncludeVersions` when current version is disabled [#14740]
2122
* Displayed error code and message when updating purged secret [#14800]
2223

2324
## Version 3.4.2

src/KeyVault/KeyVault/Commands/GetAzureKeyVaultSecret.cs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,7 @@ public override void ExecuteCmdlet()
222222
}
223223
else if (IncludeVersions)
224224
{
225-
secret = DataServiceClient.GetSecret(VaultName, Name, string.Empty);
226-
if (secret != null)
227-
{
228-
WriteObject(new PSKeyVaultSecretIdentityItem(secret));
229-
GetAndWriteSecretVersions(VaultName, Name, secret.Version);
230-
}
225+
GetAndWriteSecretVersions(VaultName, Name);
231226
}
232227
else if (InRemovedState)
233228
{
@@ -271,14 +266,14 @@ private void GetAndWriteSecrets(string vaultName, string name) =>
271266
},
272267
(options) => KVSubResourceWildcardFilter(name, DataServiceClient.GetSecrets(options)));
273268

274-
private void GetAndWriteSecretVersions(string vaultName, string name, string currentSecretVersion) =>
269+
private void GetAndWriteSecretVersions(string vaultName, string name) =>
275270
GetAndWriteObjects(new KeyVaultObjectFilterOptions
276271
{
277272
VaultName = vaultName,
278273
Name = name,
279274
NextLink = null
280275
},
281-
(options) => DataServiceClient.GetSecretVersions(options).Where(s => s.Version != currentSecretVersion));
276+
(options) => DataServiceClient.GetSecretVersions(options));
282277

283278
private void WriteSecret(PSKeyVaultSecret secret)
284279
{

0 commit comments

Comments
 (0)