Fix dynamic parameter conflict issue.

Author: shenglol

src/Resources/ResourceManager/Utilities/TemplateUtility.cs

@@ -144,51 +144,41 @@ private static RuntimeDefinedParameterDictionary ParseTemplateAndExtractParamete
             }
             if (templateParameterObject != null)
             {
-                UpdateParametersWithObject(dynamicParameters, templateParameterObject);
+                UpdateParametersWithObject(staticParameters, dynamicParameters, templateParameterObject);
             }
             if (templateParameterFilePath != null && FileUtilities.DataStore.FileExists(templateParameterFilePath))
             {
                 var parametersFromFile = ParseTemplateParameterFileContents(templateParameterFilePath);
-                UpdateParametersWithObject(dynamicParameters, new Hashtable(parametersFromFile));
+                UpdateParametersWithObject(staticParameters, dynamicParameters, new Hashtable(parametersFromFile));
             }
             if (templateParameterFilePath != null && Uri.IsWellFormedUriString(templateParameterFilePath, UriKind.Absolute))
             {
                 var parametersFromUri = ParseTemplateParameterContent(GeneralUtilities.DownloadFile(templateParameterFilePath));
-                UpdateParametersWithObject(dynamicParameters, new Hashtable(parametersFromUri));
+                UpdateParametersWithObject(staticParameters, dynamicParameters, new Hashtable(parametersFromUri));
             }
             return dynamicParameters;
         }
 
-        private static void UpdateParametersWithObject(RuntimeDefinedParameterDictionary dynamicParameters, Hashtable templateParameterObject)
+        private static void UpdateParametersWithObject(string[] staticParameters, RuntimeDefinedParameterDictionary dynamicParameters, Hashtable templateParameterObject)
         {
+            const string duplicatedParameterSuffix = "FromTemplate";
+
             if (templateParameterObject != null)
             {
-                foreach (KeyValuePair<string, RuntimeDefinedParameter> dynamicParameter in dynamicParameters)
+                foreach (string paramName in templateParameterObject.Keys)
                 {
-                    try
-                    {
-                        foreach (string key in templateParameterObject.Keys)
-                        {
-                            if (key.Equals(dynamicParameter.Key, StringComparison.InvariantCultureIgnoreCase))
-                            {
-                                if (templateParameterObject[key] is TemplateFileParameterV1)
-                                {
-                                    dynamicParameter.Value.Value = (templateParameterObject[key] as TemplateFileParameterV1).Value;
-                                }
-                                else
-                                {
-                                    dynamicParameter.Value.Value = templateParameterObject[key];
-                                }
-                                dynamicParameter.Value.IsSet = true;
-                                ((ParameterAttribute)dynamicParameter.Value.Attributes[0]).Mandatory = false;
-                            }
-                        }
-                    }
-                    catch
+                    string dynamicParamName = staticParameters.Contains(paramName, StringComparer.OrdinalIgnoreCase)
+                        ? paramName + duplicatedParameterSuffix
+                        : paramName;
+
+                    if (dynamicParameters.TryGetValue(dynamicParamName, out RuntimeDefinedParameter dynamicParameter))
                     {
-                        throw new ArgumentException(string.Format(ProjectResources.FailureParsingTemplateParameterObject,
-                                                                  dynamicParameter.Key,
-                                                                  templateParameterObject[dynamicParameter.Key]));
+                        dynamicParameter.Value = templateParameterObject[paramName] is TemplateFileParameterV1 templateFileParameterV1
+                            ? templateFileParameterV1.Value
+                            : templateParameterObject[paramName];
+
+                        dynamicParameter.IsSet = true;
+                        ((ParameterAttribute)dynamicParameter.Attributes[0]).Mandatory = false;
                     }
                 }
             }
@@ -249,8 +239,7 @@ internal static RuntimeDefinedParameter ConstructDynamicParameter(string[] stati
             RuntimeDefinedParameter runtimeParameter = new RuntimeDefinedParameter()
             {
                 // For duplicated template parameter names, add a suffix FromTemplate to distinguish them from the cmdlet parameter.
-                Name = staticParameters.Any(n => n.StartsWith(name, StringComparison.OrdinalIgnoreCase))
-                    ? name + duplicatedParameterSuffix : name,
+                Name = staticParameters.Contains(name, StringComparer.OrdinalIgnoreCase) ? name + duplicatedParameterSuffix : name,
                 ParameterType = GetParameterType(parameter.Value.Type),
                 Value = defaultValue
             };