moved provider specific logic to providers

Author: siddharth7

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup.Providers/Providers/AzureFilesPsBackupProvider.cs

@@ -85,17 +85,21 @@ public List<ContainerBase> ListProtectionContainers()
         public RestAzureNS.AzureOperationResponse TriggerBackup()
         {
             string vaultName = (string)ProviderData[VaultParams.VaultName];
-            string resourceGroupName = (string)ProviderData[VaultParams.ResourceGroupName];
+            string vaultResourceGroupName = (string)ProviderData[VaultParams.ResourceGroupName];
             ItemBase item = (ItemBase)ProviderData[ItemParams.Item];
             DateTime? expiryDateTime = (DateTime?)ProviderData[ItemParams.ExpiryDateTimeUTC];
             AzureFileShareItem azureFileShareItem = item as AzureFileShareItem;
+            BackupRequestResource triggerBackupRequest = new BackupRequestResource();
+            AzureFileShareBackupRequest azureFileShareBackupRequest = new AzureFileShareBackupRequest();
+            azureFileShareBackupRequest.RecoveryPointExpiryTimeInUTC = expiryDateTime;
+            triggerBackupRequest.Properties = azureFileShareBackupRequest;
 
             return ServiceClientAdapter.TriggerBackup(
                 IdUtils.GetValueByName(azureFileShareItem.Id, IdUtils.IdNames.ProtectionContainerName),
                 IdUtils.GetValueByName(azureFileShareItem.Id, IdUtils.IdNames.ProtectedItemName),
-                expiryDateTime,
+                triggerBackupRequest,
                 vaultName: vaultName,
-                resourceGroupName: resourceGroupName);
+                resourceGroupName: vaultResourceGroupName);
         }
 
         public RestAzureNS.AzureOperationResponse TriggerRestore()

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup.Providers/Providers/IaasVmPsBackupProvider.cs

@@ -239,11 +239,15 @@ public RestAzureNS.AzureOperationResponse TriggerBackup()
             ItemBase item = (ItemBase)ProviderData[ItemParams.Item];
             DateTime? expiryDateTime = (DateTime?)ProviderData[ItemParams.ExpiryDateTimeUTC];
             AzureVmItem iaasVmItem = item as AzureVmItem;
+            BackupRequestResource triggerBackupRequest = new BackupRequestResource();
+            IaasVMBackupRequest iaasVmBackupRequest = new IaasVMBackupRequest();
+            iaasVmBackupRequest.RecoveryPointExpiryTimeInUTC = expiryDateTime;
+            triggerBackupRequest.Properties = iaasVmBackupRequest;
 
             return ServiceClientAdapter.TriggerBackup(
                 IdUtils.GetValueByName(iaasVmItem.Id, IdUtils.IdNames.ProtectionContainerName),
                 IdUtils.GetValueByName(iaasVmItem.Id, IdUtils.IdNames.ProtectedItemName),
-                expiryDateTime,
+                triggerBackupRequest,
                 vaultName: vaultName,
                 resourceGroupName: resourceGroupName);
         }
@@ -732,7 +736,7 @@ public List<ItemBase> ListProtectedItems()
                             serviceClientExtendedInfo.RecoveryPointCount : 0);
                     ((AzureVmItem)itemModel).ExtendedInfo = extendedInfo;
                 });
-            
+
             // 3. Filter by item's Protection Status
             if (protectionStatus != 0)
             {

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup.ServiceClientAdapter/BMSAPIs/ItemAPIs.cs

@@ -131,24 +131,10 @@ public List<ProtectedItemResource> ListProtectedItem(
         public RestAzureNS.AzureOperationResponse TriggerBackup(
             string containerName,
             string itemName,
-            DateTime? expiryDateTimeUtc,
+            BackupRequestResource triggerBackupRequest,
             string vaultName = null,
             string resourceGroupName = null)
         {
-            BackupRequestResource triggerBackupRequest = new BackupRequestResource();
-            if (string.Compare(containerName.Split(';')[0], "IaasVMContainer") == 0)
-            {
-                IaasVMBackupRequest iaasVmBackupRequest = new IaasVMBackupRequest();
-                iaasVmBackupRequest.RecoveryPointExpiryTimeInUTC = expiryDateTimeUtc;
-                triggerBackupRequest.Properties = iaasVmBackupRequest;
-            }
-            else if (string.Compare(containerName.Split(';')[0], "StorageContainer") == 0)
-            {
-                AzureFileShareBackupRequest azureFileShareBackupRequest = new AzureFileShareBackupRequest();
-                azureFileShareBackupRequest.RecoveryPointExpiryTimeInUTC = expiryDateTimeUtc;
-                triggerBackupRequest.Properties = azureFileShareBackupRequest;
-            }
-
             return BmsAdapter.Client.Backups.TriggerWithHttpMessagesAsync(
                 vaultName ?? BmsAdapter.GetResourceName(),
                 resourceGroupName ?? BmsAdapter.GetResourceGroupName(),