Skip to content

Commit cfe266e

Browse files
- removed Status parameter, we always need extension status retrieved back to read AutoBackup and AutoPatching settings
1 parent 4e7a206 commit cfe266e

File tree

1 file changed

+12
-41
lines changed

1 file changed

+12
-41
lines changed

src/ResourceManager/Compute/Commands.Compute/Extension/SqlServer/GetAzureVMSqlServerExtensionCommand.cs

Lines changed: 12 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,6 @@ public class GetAzureVMSqlServerExtensionCommand : VirtualMachineExtensionBaseCm
5757
[ValidateNotNullOrEmpty]
5858
public string Name { get; set; }
5959

60-
[Parameter(
61-
Position = 3,
62-
ValueFromPipelineByPropertyName = true,
63-
HelpMessage = "To show the status.")]
64-
[ValidateNotNullOrEmpty]
65-
public SwitchParameter Status { get; set; }
66-
6760
public override void ExecuteCmdlet()
6861
{
6962
base.ExecuteCmdlet();
@@ -73,45 +66,21 @@ public override void ExecuteCmdlet()
7366
Name = VirtualMachineSqlServerExtensionContext.ExtensionPublishedNamespace + "." + VirtualMachineSqlServerExtensionContext.ExtensionPublishedName;
7467
}
7568

76-
if (Status)
77-
{
78-
var result = VirtualMachineExtensionClient.GetWithInstanceView(ResourceGroupName, VMName, Name);
79-
var extension = result.ToPSVirtualMachineExtension(ResourceGroupName);
69+
var result = VirtualMachineExtensionClient.GetWithInstanceView(ResourceGroupName, VMName, Name);
70+
var extension = result.ToPSVirtualMachineExtension(ResourceGroupName);
8071

81-
if (
82-
extension.Publisher.Equals(VirtualMachineSqlServerExtensionContext.ExtensionPublishedNamespace,
83-
StringComparison.InvariantCultureIgnoreCase) &&
84-
extension.ExtensionType.Equals(VirtualMachineSqlServerExtensionContext.ExtensionPublishedName,
85-
StringComparison.InvariantCultureIgnoreCase))
86-
{
87-
WriteObject(GetSqlServerExtensionContext(extension));
88-
}
89-
else
90-
{
91-
WriteObject(null);
92-
}
72+
if (
73+
extension.Publisher.Equals(VirtualMachineSqlServerExtensionContext.ExtensionPublishedNamespace,
74+
StringComparison.InvariantCultureIgnoreCase) &&
75+
extension.ExtensionType.Equals(VirtualMachineSqlServerExtensionContext.ExtensionPublishedName,
76+
StringComparison.InvariantCultureIgnoreCase))
77+
{
78+
WriteObject(GetSqlServerExtensionContext(extension));
9379
}
9480
else
9581
{
96-
var result = VirtualMachineExtensionClient.Get(ResourceGroupName, VMName, Name);
97-
var extension = result.ToPSVirtualMachineExtension(ResourceGroupName);
98-
99-
if (
100-
extension.Publisher.Equals(
101-
VirtualMachineSqlServerExtensionContext.ExtensionPublishedNamespace,
102-
StringComparison.InvariantCultureIgnoreCase) &&
103-
extension.ExtensionType.Equals(
104-
VirtualMachineSqlServerExtensionContext.ExtensionPublishedName,
105-
StringComparison.InvariantCultureIgnoreCase))
106-
{
107-
WriteObject(GetSqlServerExtensionContext(extension));
108-
}
109-
else
110-
{
111-
WriteObject(null);
112-
}
82+
WriteObject(null);
11383
}
114-
11584
}
11685

11786
private VirtualMachineSqlServerExtensionContext GetSqlServerExtensionContext(PSVirtualMachineExtension extension)
@@ -138,6 +107,8 @@ private VirtualMachineSqlServerExtensionContext GetSqlServerExtensionContext(PSV
138107
PublicSettings = JsonConvert.SerializeObject(extensionPublicSettings),
139108
ProtectedSettings = extension.ProtectedSettings,
140109
ProvisioningState = extension.ProvisioningState,
110+
AutoBackupSettings = extensionPublicSettings.AutoBackupSettings,
111+
AutoPatchingSettings = extensionPublicSettings.AutoPatchingSettings,
141112
Statuses = extension.Statuses
142113
};
143114

0 commit comments

Comments
 (0)