Fix BufferedProtocol.get_buffer to accept *sizehint* argument

Author: 1st1

tests/test_tcp.py

@@ -631,6 +631,8 @@ class Test_UV_TCP(_TestTCP, tb.UVTestCase):
 
     def test_create_server_buffered_1(self):
         SIZE = 123123
+        eof = False
+        done = False
 
         class Proto(asyncio.BaseProtocol):
             def connection_made(self, tr):
@@ -639,7 +641,7 @@ def connection_made(self, tr):
                 self.data = bytearray(50)
                 self.buf = memoryview(self.data)
 
-            def get_buffer(self):
+            def get_buffer(self, sizehint):
                 return self.buf
 
             def buffer_updated(self, nbytes):
@@ -648,7 +650,12 @@ def buffer_updated(self, nbytes):
                     self.tr.write(b'hello')
 
             def eof_received(self):
-                pass
+                nonlocal eof
+                eof = True
+
+            def connection_lost(self, exc):
+                nonlocal done
+                done = exc
 
         async def test():
             port = tb.find_free_port()
@@ -666,13 +673,15 @@ async def test():
             await srv.wait_closed()
 
         self.loop.run_until_complete(test())
+        self.assertTrue(eof)
+        self.assertIsNone(done)
 
     def test_create_server_buffered_2(self):
         class ProtoExc(asyncio.BaseProtocol):
             def __init__(self):
                 self._lost_exc = None
 
-            def get_buffer(self):
+            def get_buffer(self, sizehint):
                 1 / 0
 
             def buffer_updated(self, nbytes):
@@ -688,7 +697,7 @@ class ProtoZeroBuf1(asyncio.BaseProtocol):
             def __init__(self):
                 self._lost_exc = None
 
-            def get_buffer(self):
+            def get_buffer(self, sizehint):
                 return bytearray(0)
 
             def buffer_updated(self, nbytes):
@@ -704,7 +713,7 @@ class ProtoZeroBuf2(asyncio.BaseProtocol):
             def __init__(self):
                 self._lost_exc = None
 
-            def get_buffer(self):
+            def get_buffer(self, sizehint):
                 return memoryview(bytearray(0))
 
             def buffer_updated(self, nbytes):
@@ -720,7 +729,7 @@ class ProtoUpdatedError(asyncio.BaseProtocol):
             def __init__(self):
                 self._lost_exc = None
 
-            def get_buffer(self):
+            def get_buffer(self, sizehint):
                 return memoryview(bytearray(100))
 
             def buffer_updated(self, nbytes):

uvloop/handles/stream.pyx

@@ -909,7 +909,7 @@ cdef void __uv_stream_buffered_alloc(uv.uv_handle_t* stream,
 
     sc._read_pybuf_acquired = 0
     try:
-        buf = sc._protocol_get_buffer()
+        buf = sc._protocol_get_buffer(suggested_size)
         PyObject_GetBuffer(buf, pybuf, PyBUF_WRITABLE)
         got_buf = 1
     except BaseException as exc: