Merge remote-tracking branch 'origin/main' into color_fix

Author: behackl

.github/ISSUE_TEMPLATE/installation_issue.md

@@ -11,7 +11,7 @@ assignees: ''
 
 - [ ] I have followed the latest version of the
       [installation instructions](https://docs.manim.community/en/stable/installation.html).
-- [ ] I have checked the [troubleshooting page](https://docs.manim.community/en/stable/installation/troubleshooting.html) and my problem is either not mentioned there,
+- [ ] I have checked the [installation FAQ](https://docs.manim.community/en/stable/faq/installation.html) and my problem is either not mentioned there,
       or the solution given there does not help.
 
 ## Description of error

.github/workflows/ci.yml

@@ -13,57 +13,6 @@ on:
       - main
 
 jobs:
-  test-arm:
-    runs-on: self-hosted
-    env:
-      DISPLAY: :0
-      PYTEST_ADDOPTS: "--color=yes" # colors in pytest
-    strategy:
-      fail-fast: false
-      matrix:
-        python: ["3.8.16", "3.11.1"]
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Check Runner
-        run: |
-          which latex
-          which ffmpeg
-          latex --version
-          ffmpeg -version
-          which python
-          python --version
-
-      - name: Activate Python ${{ matrix.python }}
-        run: |
-          echo "/root/.pyenv/versions/${{ matrix.python }}/bin:/root/.local/bin:$PATH" > $GITHUB_PATH
-
-      - name: Show Python Version
-        run: |
-          python --version --version
-
-      - name: Install Manim
-        run: |
-          poetry config virtualenvs.prefer-active-python true
-          poetry install
-
-      - name: Run tests
-        run: |
-          poetry run pytest
-
-      - name: Run module doctests
-        run: |
-          poetry run pytest --cov-append --doctest-modules --ignore-glob="*opengl*" manim
-
-      - name: Run doctests in rst files
-        run: |
-          cd docs && poetry run make doctest O=-tskip-manim
-
-      # upload coverage report
-      - name: Upload coverage
-        uses: codecov/codecov-action@v3
-
   test:
     runs-on: ${{ matrix.os }}
     env:
@@ -184,7 +133,7 @@ jobs:
           echo "Install Tinytex"
           Invoke-WebRequest "https://github.com/yihui/tinytex-releases/releases/download/daily/TinyTeX-1.zip" -O "$($env:TMP)\TinyTex.zip"
           Expand-Archive -LiteralPath "$($env:TMP)\TinyTex.zip" -DestinationPath "$($PWD)\ManimCache\LatexWindows"
-          $env:Path = "$($PWD)\ManimCache\LatexWindows\TinyTeX\bin\win32;$($env:PATH)"
+          $env:Path = "$($PWD)\ManimCache\LatexWindows\TinyTeX\bin\windows;$($env:PATH)"
           tlmgr update --self
           foreach ($c in $tinyTexPackages){
             $c=$c.Trim()
@@ -196,7 +145,7 @@ jobs:
       - name: Add Windows dependencies to PATH
         if: runner.os == 'Windows'
         run: |
-          $env:Path += ";" + "$($PWD)\ManimCache\LatexWindows\TinyTeX\bin\win32"
+          $env:Path += ";" + "$($PWD)\ManimCache\LatexWindows\TinyTeX\bin\windows"
           $env:Path = "$env:USERPROFILE\.poetry\bin;$($env:PATH)"
           echo "$env:Path" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
 

.pre-commit-config.yaml

@@ -13,7 +13,7 @@ repos:
       - id: check-toml
         name: Validate Poetry
   - repo: https://github.com/pycqa/isort
-    rev: 5.11.4
+    rev: 5.12.0
     hooks:
       - id: isort
         name: isort (python)
@@ -30,16 +30,16 @@ repos:
         name: Update code to new python versions
         args: [--py37-plus]
   - repo: https://github.com/pre-commit/pygrep-hooks
-    rev: v1.9.0
+    rev: v1.10.0
     hooks:
       - id: python-check-blanket-noqa
         name: Precision flake ignores
   - repo: https://github.com/psf/black
-    rev: 22.12.0
+    rev: 23.1.0
     hooks:
       - id: black
   - repo: https://github.com/asottile/blacken-docs
-    rev: v1.12.1
+    rev: 1.13.0
     hooks:
       - id: blacken-docs
         additional_dependencies: [black==22.3.0]
@@ -58,7 +58,7 @@ repos:
             flake8-simplify==0.14.1,
           ]
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.991
+    rev: v1.1.1
     hooks:
       - id: mypy
         additional_dependencies:
@@ -71,7 +71,8 @@ repos:
           ]
 
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.2
+    rev: v2.2.4
     hooks:
       - id: codespell
+        files: ^.*\.(py|md|rst)$
         args: ["-L", "medias,nam"]

docs/i18n/gettext/reference/manim.animation.animation.Animation.pot

@@ -171,12 +171,12 @@ msgstr ""
 
 #: ../../../manim/animation/animation.py:docstring of manim.animation.animation.Animation.begin:1:<autosummary>:1
 #: ../../../manim/animation/animation.py:docstring of manim.animation.animation.Animation.is_introducer:1
-msgid "Test if a the animation is an introducer."
+msgid "Test if the animation is an introducer."
 msgstr ""
 
 #: ../../../manim/animation/animation.py:docstring of manim.animation.animation.Animation.begin:1:<autosummary>:1
 #: ../../../manim/animation/animation.py:docstring of manim.animation.animation.Animation.is_remover:1
-msgid "Test if a the animation is a remover."
+msgid "Test if the animation is a remover."
 msgstr ""
 
 #: ../../../manim/animation/animation.py:docstring of manim.animation.animation.Animation.begin:1:<autosummary>:1

docs/i18n/stripUntranslatable.awk

@@ -25,7 +25,7 @@ BEGIN {
 	# The file location of where to put everything
 	# that has been stripped out
 	untranslatablefile="./untranslatable.po"
-	# Wether we are still reading the licence text
+	# Whether we are still reading the licence text
 	licencetext=1
 }
 

docs/source/conf.py

@@ -138,8 +138,8 @@
 
 # external links
 extlinks = {
-    "issue": ("https://github.com/ManimCommunity/manim/issues/%s", "#"),
-    "pr": ("https://github.com/ManimCommunity/manim/pull/%s", "#"),
+    "issue": ("https://github.com/ManimCommunity/manim/issues/%s", "#%s"),
+    "pr": ("https://github.com/ManimCommunity/manim/pull/%s", "#%s"),
 }
 
 # opengraph settings

manim/animation/animation.py

@@ -457,7 +457,7 @@ def set_name(self, name: str) -> Animation:
         return self
 
     def is_remover(self) -> bool:
-        """Test if a the animation is a remover.
+        """Test if the animation is a remover.
 
         Returns
         -------
@@ -467,7 +467,7 @@ def is_remover(self) -> bool:
         return self.remover
 
     def is_introducer(self) -> bool:
-        """Test if a the animation is an introducer.
+        """Test if the animation is an introducer.
 
         Returns
         -------
@@ -528,8 +528,8 @@ class Wait(Animation):
     stop_condition
         A function without positional arguments that evaluates to a boolean.
         The function is evaluated after every new frame has been rendered.
-        Playing the animation only stops after the return value is truthy.
-        Overrides the specified ``run_time``.
+        Playing the animation stops after the return value is truthy, or
+        after the specified ``run_time`` has passed.
     frozen_frame
         Controls whether or not the wait animation is static, i.e., corresponds
         to a frozen frame. If ``False`` is passed, the render loop still

manim/animation/creation.py

@@ -301,7 +301,7 @@ def construct(self):
 
         class ShowWriteReversed(Scene):
             def construct(self):
-                self.play(Write(Text("Hello", font_size=144), reverse=True))
+                self.play(Write(Text("Hello", font_size=144), reverse=True, remover=False))
 
     Tests
     -----
@@ -404,7 +404,6 @@ def __init__(
         reverse: bool = True,
         **kwargs,
     ) -> None:
-
         run_time: float | None = kwargs.pop("run_time", None)
         lag_ratio: float | None = kwargs.pop("lag_ratio", None)
         run_time, lag_ratio = self._set_default_config_from_length(

manim/animation/speedmodifier.py

@@ -97,7 +97,6 @@ def __init__(
         affects_speed_updaters: bool = True,
         **kwargs,
     ) -> None:
-
         if issubclass(type(anim), AnimationGroup):
             self.anim = type(anim)(
                 *map(self.setup, anim.animations),

manim/animation/transform.py

@@ -211,8 +211,7 @@ def create_target(self) -> Mobject:
     def clean_up_from_scene(self, scene: Scene) -> None:
         super().clean_up_from_scene(scene)
         if self.replace_mobject_with_target_in_scene:
-            scene.remove(self.mobject)
-            scene.add(self.target_mobject)
+            scene.replace(self.mobject, self.target_mobject)
 
     def get_all_mobjects(self) -> Sequence[Mobject]:
         return [

manim/animation/transform_matching_parts.py

@@ -76,7 +76,6 @@ def __init__(
         key_map: dict | None = None,
         **kwargs,
     ):
-
         if isinstance(mobject, OpenGLVMobject):
             group_type = OpenGLVGroup
         elif isinstance(mobject, OpenGLMobject):

manim/camera/mapping_camera.py

@@ -64,6 +64,7 @@ def capture_mobjects(self, mobjects, **kwargs):
 # TODO: Add optional separator borders between cameras (or perhaps peel this off into a
 # CameraPlusOverlay class)
 
+
 # TODO, the classes below should likely be deleted
 class OldMultiCamera(Camera):
     def __init__(self, *cameras_with_start_positions, **kwargs):

manim/camera/three_d_camera.py

@@ -85,7 +85,8 @@ def capture_mobjects(self, mobjects, **kwargs):
         super().capture_mobjects(mobjects, **kwargs)
 
     def get_value_trackers(self):
-        """Returns list of ValueTrackers of phi, theta, focal_distance and gamma
+        """A list of :class:`ValueTrackers <.ValueTracker>` of phi, theta, focal_distance,
+        gamma and zoom.
 
         Returns
         -------
@@ -380,6 +381,7 @@ def add_fixed_orientation_mobjects(
             The function which returns the centerpoint
             with respect to which the mobject will be oriented, by default None
         """
+
         # This prevents the computation of mobject.get_center
         # every single time a projection happens
         def get_static_center_func(mobject):