Merge branch 'experimental' into color_fix

Author: MrDiver

.github/codeql.yml

@@ -0,0 +1,16 @@
+query-filters:
+    - exclude:
+          id: py/init-calls-subclass
+    - exclude:
+          id: py/unexpected-raise-in-special-method
+    - exclude:
+          id: py/modification-of-locals
+    - exclude:
+          id: py/multiple-calls-to-init
+    - exclude:
+          id: py/missing-call-to-init
+paths:
+    - manim
+paths-ignore:
+    - tests/
+    - example_scenes/

.github/workflows/codeql.yml

@@ -0,0 +1,42 @@
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+  schedule:
+    - cron: "21 16 * * 3"
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ python ]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          config-file: ./.github/codeql.yml
+          queries: +security-and-quality
+
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2
+        with:
+          category: "/language:${{ matrix.language }}"

.pre-commit-config.yaml

@@ -13,7 +13,7 @@ repos:
       - id: check-toml
         name: Validate Poetry
   - repo: https://github.com/pycqa/isort
-    rev: 5.10.1
+    rev: 5.11.4
     hooks:
       - id: isort
         name: isort (python)

CITATION.cff

@@ -4,10 +4,10 @@ authors:
   -
     name: "The Manim Community Developers"
 cff-version: "1.2.0"
-date-released: 2022-12-08
+date-released: 2022-12-26
 license: MIT
 message: "We acknowledge the importance of good software to support research, and we note that research becomes more valuable when it is communicated effectively. To demonstrate the value of Manim, we ask that you cite Manim in your work."
 title: Manim – Mathematical Animation Framework
 url: "https://www.manim.community/"
-version: "v0.17.1"
+version: "v0.17.2"
 ...

docs/source/changelog.rst

@@ -5,6 +5,7 @@ Changelog
 
 .. toctree::
 
+    changelog/0.17.2-changelog
     changelog/0.17.1-changelog
     changelog/0.17.0-changelog
     changelog/0.16.0-changelog

docs/source/changelog/0.17.2-changelog.rst

@@ -0,0 +1,61 @@
+*******
+v0.17.2
+*******
+
+:Date: December 26, 2022
+
+Contributors
+============
+
+A total of 5 people contributed to this
+release. People with a '+' by their names authored a patch for the first
+time.
+
+* CaftBotti +
+* Tristan Schulz
+* lgtm-com[bot] +
+
+
+The patches included in this release have been reviewed by
+the following contributors.
+
+* Benjamin Hackl
+* Naveen M K
+* Tristan Schulz
+
+Pull requests merged
+====================
+
+A total of 7 pull requests were merged for this release.
+
+Fixed bugs
+----------
+
+* :pr:`3089`: Fixed OpenGL mobjects like :class:`.Surface` by reordering init calls
+
+
+Documentation-related changes
+-----------------------------
+
+* :pr:`3073`: Fixed typo: "Whetherer" to "Whether"
+
+
+* :pr:`3074`: Fixed typo in a comment
+
+
+Code quality improvements and similar refactors
+-----------------------------------------------
+
+* :pr:`3024`: Add CodeQL workflow for GitHub code scanning
+
+
+* :pr:`3079`: Updated CI syntax for runner version >= 2.298.2
+
+
+* :pr:`3084`: Properly setup CodeQL
+
+
+New releases
+------------
+
+* :pr:`3090`: Prepared new Hotfix Release: ``v0.17.2``

manim/cli/render/render_options.py

@@ -83,7 +83,7 @@ def validate_resolution(ctx, param, value):
         "--resolution",
         callback=validate_resolution,
         default=None,
-        help="Resolution in (W,H) for when 16:9 aspect ratio isn't possible.",
+        help='Resolution in "W,H" for when 16:9 aspect ratio isn\'t possible.',
     ),
     option(
         "--fps",

manim/mobject/graph.py

@@ -627,13 +627,11 @@ def _create_vertex(
                 f"Vertex identifier '{vertex}' is already used for a vertex in this graph.",
             )
 
-        if isinstance(label, (Mobject, OpenGLMobject)):
-            label = label
-        elif label is True:
+        if label is True:
             label = MathTex(vertex, fill_color=label_fill_color)
         elif vertex in self._labels:
             label = self._labels[vertex]
-        else:
+        elif not isinstance(label, (Mobject, OpenGLMobject)):
             label = None
 
         base_vertex_config = copy(self.default_vertex_config)