Skip to content

Commit 22f8b5f

Browse files
JonRowebenoittgt
authored andcommitted
Add spec to prevent zombie status
1 parent 2cb7a09 commit 22f8b5f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

spec/integration/bisect_spec.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,19 @@ def bisect(cli_args, expected_status=nil)
3333
end
3434
end
3535

36-
context "when the bisect commasaturingnd is long" do
36+
context "when the bisect command saturates the pipe" do
3737
# On OSX and Linux a file descriptor limit meant that the bisect process got stuck at a certain limit.
3838
# This test demonstrates that we can run large bisects above this limit (found to be at time of commit).
3939
# See: https://github.com/rspec/rspec-core/pull/2669
4040
it 'does not hit pipe size limit and does not get stuck' do
4141
output = bisect(%W[spec/rspec/core/resources/blocking_pipe_bisect_spec.rb_], 1)
4242
expect(output).to include("No failures found.")
4343
end
44+
45+
it 'does not leave zombie processes', :unless => RSpec::Support::OS.windows? do
46+
bisect(%W[spec/rspec/core/resources/blocking_pipe_bisect_spec.rb_], 1)
47+
expect(%x[ps -ho pid,state]).to_not include("Z")
48+
end
4449
end
4550
end
4651
end

0 commit comments

Comments
 (0)