Skip to content

Commit 3838f7b

Browse files
committed
Rename option for FailureList formatter to "failures"
The name was not matching case statement in formatters.rb and it is much simplier to have an argument with that name. Discussion: - https://github.com/rspec/rspec-core/pull/2624/files#r284776400
1 parent a7a153d commit 3838f7b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/rspec/core/formatters.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ def built_in_formatter(key)
213213
JsonFormatter
214214
when 'bisect-drb'
215215
BisectDRbFormatter
216-
when 'f', 'failure_list'
216+
when 'f', 'failures'
217217
FailureListFormatter
218218
end
219219
end

lib/rspec/core/option_parser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def parser(options)
112112
' [d]ocumentation (group and example names)',
113113
' [h]tml',
114114
' [j]son',
115-
' [f]ailure list (suitable for editors integration)',
115+
' [f]ailures ("file:line:reason", suitable for editors integration)',
116116
' custom formatter class name') do |o|
117117
options[:formatters] ||= []
118118
options[:formatters] << [o]

spec/rspec/core/formatters/failure_list_formatter_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module RSpec::Core::Formatters
55
include FormatterSupport
66

77
it 'produces the expected full output' do
8-
output = run_example_specs_with_formatter('failure_list')
8+
output = run_example_specs_with_formatter('failures')
99
expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
1010
|./spec/rspec/core/resources/formatter_specs.rb:4:is marked as pending but passes
1111
|./spec/rspec/core/resources/formatter_specs.rb:36:fails

0 commit comments

Comments
 (0)