Disable strict cops and fix other violations

Author: soulcutter

.rubocop.yml

@@ -14,6 +14,10 @@ Encoding:
   Exclude:
     - lib/rspec/core/formatters/exception_presenter.rb
 
+# This should go down over time.
+Metrics/AbcSize:
+  Max: 40
+
 # This should go down over time.
 Metrics/LineLength:
   Max: 130
@@ -26,6 +30,9 @@ Metrics/MethodLength:
 Metrics/CyclomaticComplexity:
   Max: 12
 
+Metrics/PerceivedComplexity:
+  Max: 15
+
 Lint/HandleExceptions:
   Exclude:
     - lib/rspec/core/example.rb
@@ -53,14 +60,21 @@ Style/SpaceAroundOperators:
       - '==='
       - '=>'
       - '<<'
+      - '||'
 
 Style/AccessModifierIndentation:
   Enabled: false
 
+Style/RegexpLiteral:
+  Enabled: false
+
 # This could change depending of the style used
 Style/MultilineOperationIndentation:
   Enabled: false
 
+Style/BarePercentLiterals:
+  Enabled: false
+
 # Exclude the default spec_helper to make it easier to uncomment out
 # default settings (for both users and the Cucumber suite).
 Style/BlockComments:

lib/rspec/core/configuration.rb

@@ -580,7 +580,7 @@ def mock_with(framework)
           end
 
         new_name, old_name = [framework_module, @mock_framework].map do |mod|
-          mod.respond_to?(:framework_name) ?  mod.framework_name : :unnamed
+          mod.respond_to?(:framework_name) ? mod.framework_name : :unnamed
         end
 
         unless new_name == old_name
@@ -1731,7 +1731,8 @@ def extract_location(path)
 
         if match
           captures = match.captures
-          path, lines = captures[0], captures[1][1..-1].split(":").map { |n| n.to_i }
+          path = captures[0]
+          lines = captures[1][1..-1].split(":").map(&:to_i)
           filter_manager.add_location path, lines
         else
           path, scoped_ids = Example.parse_id(path)

lib/rspec/core/configuration_options.rb

@@ -64,7 +64,7 @@ def force?(key)
       end
 
       def order(keys)
-        OPTIONS_ORDER.reverse.each do |key|
+        OPTIONS_ORDER.reverse_each do |key|
           keys.unshift(key) if keys.delete(key)
         end
         keys

lib/rspec/core/notifications.rb

@@ -10,6 +10,7 @@ module Notifications
     # @private
     module NullColorizer
       module_function
+
       def wrap(line, _code_or_symbol)
         line
       end

lib/rspec/core/option_parser.rb

@@ -252,7 +252,6 @@ def parser(options)
             raise OptionParser::InvalidOption.new
           end
         end
-
       end
     end
     # rubocop:enable Metrics/AbcSize