Skip to content

Commit 5fc0dfc

Browse files
usiemsmrbean-bremen
authored andcommitted
Fix crash when using QObject::disconnect method (when multi-threading is enabled)
It seems this is done with a slot call, which gives up the GIL, but the GIL is needed in the destructor of the PythonQtSignalReceiver when a callable target was given. Fix this by simply using a PythonQtSafeObjectPtr for the _callable.
1 parent 04a7df7 commit 5fc0dfc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/PythonQtSignalReceiver.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class PYTHONQT_EXPORT PythonQtSignalTarget {
9494
int _signalId;
9595
int _slotId;
9696
const PythonQtMethodInfo* _methodInfo;
97-
PythonQtObjectPtr _callable;
97+
PythonQtSafeObjectPtr _callable;
9898
};
9999

100100
//! base class for signal receivers

0 commit comments

Comments
 (0)