feat: improve checkhealth

## Details

- check for `html` parser if `html` configuration is not disabled
- always make the same checks, but take into account whether that thing
  is required, rather than avoiding the check entirely
- add `markview.nvim` as a conflicting plugin
- other unrelated minor refactor changes, nothing functionally different

Author: MeanderingProgrammer

benches/util.lua

@@ -54,8 +54,8 @@ end
 
 ---@param expected integer
 function M.num_marks(expected)
-    local namespace = require('render-markdown.core.ui').namespace
-    local marks = vim.api.nvim_buf_get_extmarks(0, namespace, 0, -1, {})
+    local ui = require('render-markdown.core.ui')
+    local marks = vim.api.nvim_buf_get_extmarks(0, ui.ns, 0, -1, {})
     assert.are.same(expected, #marks)
 end
 

doc/render-markdown.txt

@@ -1,4 +1,4 @@
-*render-markdown.txt*         For 0.10.0         Last change: 2025 February 28
+*render-markdown.txt*           For 0.10.0          Last change: 2025 March 02
 
 ==============================================================================
 Table of Contents                          *render-markdown-table-of-contents*

lua/render-markdown/core/extmark.lua

@@ -14,25 +14,35 @@ function Extmark.new(mark)
 end
 
 ---@return render.md.Mark
-function Extmark:get_mark()
+function Extmark:get()
     return self.mark
 end
 
----@param ns_id integer
+---@param range? render.md.Range
+---@return boolean
+function Extmark:inside(range)
+    if range == nil then
+        return false
+    end
+    local row = self.mark.start_row
+    return range:contains(row, row)
+end
+
+---@param ns integer
 ---@param buf integer
-function Extmark:show(ns_id, buf)
+function Extmark:show(ns, buf)
     if self.id == nil then
         local mark = self.mark
         mark.opts.strict = false
-        self.id = vim.api.nvim_buf_set_extmark(buf, ns_id, mark.start_row, mark.start_col, mark.opts)
+        self.id = vim.api.nvim_buf_set_extmark(buf, ns, mark.start_row, mark.start_col, mark.opts)
     end
 end
 
----@param ns_id integer
+---@param ns integer
 ---@param buf integer
-function Extmark:hide(ns_id, buf)
+function Extmark:hide(ns, buf)
     if self.id ~= nil then
-        vim.api.nvim_buf_del_extmark(buf, ns_id, self.id)
+        vim.api.nvim_buf_del_extmark(buf, ns, self.id)
         self.id = nil
     end
 end

lua/render-markdown/core/ui.lua

@@ -34,7 +34,7 @@ end
 ---@class render.md.Ui
 local M = {}
 
-M.namespace = vim.api.nvim_create_namespace('render-markdown.nvim')
+M.ns = vim.api.nvim_create_namespace('render-markdown.nvim')
 
 function M.invalidate_cache()
     for buf, buffer_state in pairs(Cache.states) do
@@ -54,9 +54,8 @@ function M.get_row_marks(buf, win)
 
     local marks = {}
     for _, extmark in ipairs(buffer_state:get_marks()) do
-        local mark = extmark:get_mark()
-        if hidden:contains(mark.start_row, mark.start_row) then
-            table.insert(marks, mark)
+        if extmark:inside(hidden) then
+            table.insert(marks, extmark:get())
         end
     end
     return row, marks
@@ -66,7 +65,7 @@ end
 ---@param buf integer
 ---@param buffer_state render.md.BufferState
 function M.clear(buf, buffer_state)
-    vim.api.nvim_buf_clear_namespace(buf, M.namespace, 0, -1)
+    vim.api.nvim_buf_clear_namespace(buf, M.ns, 0, -1)
     buffer_state:set_marks(nil)
 end
 
@@ -142,11 +141,10 @@ function M.run_update(buf, win, change)
         local hidden = config:hidden(mode, row)
         local extmarks = buffer_state:get_marks()
         for _, extmark in ipairs(extmarks) do
-            local mark = extmark:get_mark()
-            if mark.conceal and hidden ~= nil and hidden:contains(mark.start_row, mark.start_row) then
-                extmark:hide(M.namespace, buf)
+            if extmark:get().conceal and extmark:inside(hidden) then
+                extmark:hide(M.ns, buf)
             else
-                extmark:show(M.namespace, buf)
+                extmark:show(M.ns, buf)
             end
         end
         state.on.render({ buf = buf })

lua/render-markdown/handler/latex.lua

@@ -48,7 +48,7 @@ function M.parse(ctx)
         table.insert(expressions, '')
     end
 
-    local latex_lines = Iter.list.map(expressions, function(expression)
+    local lines = Iter.list.map(expressions, function(expression)
         return { { expression, latex.highlight } }
     end)
 
@@ -57,7 +57,7 @@ function M.parse(ctx)
 
     local marks = List.new_marks(ctx.buf, true)
     marks:add(false, row, 0, {
-        virt_lines = latex_lines,
+        virt_lines = lines,
         virt_lines_above = above,
     })
     return marks:get()

lua/render-markdown/health.lua

@@ -5,7 +5,7 @@ local state = require('render-markdown.state')
 local M = {}
 
 ---@private
-M.version = '8.0.14'
+M.version = '8.0.15'
 
 function M.check()
     M.start('version')
@@ -21,15 +21,15 @@ function M.check()
         vim.health.error(message)
     end
 
-    local latex = state.get(0).latex
-    local latex_advice = 'Disable LaTeX support to avoid this warning by setting { latex = { enabled = false } }'
+    local config = state.get(0)
+    local latex, latex_advice = config.latex, M.disable_advice('latex')
+    local html, html_advice = config.html, M.disable_advice('html')
 
     M.start('treesitter')
-    M.check_parser('markdown')
-    M.check_parser('markdown_inline')
-    if latex.enabled then
-        M.check_parser('latex', latex_advice)
-    end
+    M.check_parser('markdown', true)
+    M.check_parser('markdown_inline', true)
+    M.check_parser('latex', latex.enabled, latex_advice)
+    M.check_parser('html', html.enabled, html_advice)
     M.check_highlight('markdown')
 
     M.start('icons')
@@ -41,14 +41,11 @@ function M.check()
     end
 
     M.start('executables')
-    if latex.enabled then
-        M.check_executable(latex.converter, latex_advice)
-    else
-        vim.health.ok('none to check')
-    end
+    M.check_executable(latex.converter, latex.enabled, latex_advice)
 
     M.start('conflicts')
     M.check_plugin('headlines')
+    M.check_plugin('markview')
     M.check_plugin('obsidian', function(obsidian)
         if obsidian.get_client().opts.ui.enable == false then
             return nil
@@ -79,15 +76,31 @@ end
 
 ---@private
 ---@param language string
----@param advice? string
-function M.check_parser(language, advice)
+---@return string[]
+function M.disable_advice(language)
+    return {
+        string.format('Disable %s support to avoid this warning', language),
+        string.format('Set { %s = { enabled = false } }', language),
+    }
+end
+
+---@private
+---@param language string
+---@param required boolean
+---@param advice? string[]
+function M.check_parser(language, required, advice)
     local has_parser = pcall(vim.treesitter.get_parser, 0, language)
     if has_parser then
         vim.health.ok(language .. ': parser installed')
-    elseif advice == nil then
-        vim.health.error(language .. ': parser not installed')
     else
-        vim.health.warn(language .. ': parser not installed', advice)
+        local message = language .. ': parser not installed'
+        if not required then
+            vim.health.ok(message)
+        elseif advice ~= nil then
+            vim.health.warn(message, advice)
+        else
+            vim.health.error(message)
+        end
     end
 end
 
@@ -109,14 +122,20 @@ end
 
 ---@private
 ---@param name string
----@param advice? string
-function M.check_executable(name, advice)
+---@param required boolean
+---@param advice? string[]
+function M.check_executable(name, required, advice)
     if vim.fn.executable(name) == 1 then
         vim.health.ok(name .. ': installed')
-    elseif advice == nil then
-        vim.health.error(name .. ': not installed')
     else
-        vim.health.warn(name .. ': not installed', advice)
+        local message = name .. ': not installed'
+        if not required then
+            vim.health.ok(message)
+        elseif advice ~= nil then
+            vim.health.warn(message, advice)
+        else
+            vim.health.error(message)
+        end
     end
 end
 

lua/render-markdown/lib/list.lua

@@ -29,14 +29,6 @@ function Marks:get()
     return self.marks
 end
 
----@param element boolean|render.md.Element
----@param node render.md.Node
----@param opts vim.api.keyset.set_extmark
----@return boolean
-function Marks:add_start(element, node, opts)
-    return self:add(element, node.start_row, node.start_col, opts)
-end
-
 ---@param element boolean|render.md.Element
 ---@param node render.md.Node
 ---@param opts vim.api.keyset.set_extmark

lua/render-markdown/render/base.lua

@@ -44,7 +44,7 @@ function Base:sign(text, highlight)
     if highlight ~= nil then
         sign_highlight = colors.combine(highlight, sign_highlight)
     end
-    self.marks:add_start('sign', self.node, {
+    self.marks:add('sign', self.node.start_row, self.node.start_col, {
         sign_text = text,
         sign_hl_group = sign_highlight,
     })
@@ -137,7 +137,7 @@ end
 
 ---@protected
 ---@param width integer
----@param highlight? string
+---@param highlight? string|string[]
 ---@return render.md.line.Text
 function Base:pad(width, highlight)
     return { Str.pad(width), highlight or self.config.padding.highlight }

lua/render-markdown/render/code.lua

@@ -129,8 +129,7 @@ function Render:language()
         self:sign(icon, icon_highlight)
     end
 
-    local text = icon .. ' '
-    local highlight = { icon_highlight }
+    local text, highlight = icon .. ' ', { icon_highlight }
     if self.code.border ~= 'none' then
         table.insert(highlight, self.code.highlight)
     end
@@ -140,10 +139,11 @@ function Render:language()
             -- Code blocks pick up varying amounts of leading white space depending
             -- on the context they are in. This is lumped into the delimiter node
             -- and as a result, after concealing, the extmark would be shifted.
-            local padding = Str.spaces('start', self.node.text) + self.data.language_padding
-            text = Str.pad(padding) .. text .. node.text
+            local spaces = Str.spaces('start', self.node.text)
+            local padding = Str.pad(spaces + self.data.language_padding)
+            text = padding .. text .. node.text
         end
-        return self.marks:add_start('code_language', node, {
+        return self.marks:add('code_language', node.start_row, node.start_col, {
             virt_text = { { text, highlight } },
             virt_text_pos = 'inline',
         })

lua/render-markdown/render/html_tag.lua

@@ -22,7 +22,7 @@ end
 function Render:render()
     self:hide('start_tag')
     self:hide('end_tag')
-    self.marks:add_start(false, self.node, {
+    self.marks:add(false, self.node.start_row, self.node.start_col, {
         virt_text = { { self.tag.icon, self.tag.highlight } },
         virt_text_pos = 'inline',
     })

lua/render-markdown/render/table.lua

@@ -378,7 +378,7 @@ function Render:full()
         local line = spaces > 0 and { self:pad(spaces) } or {}
         local highlight = above and self.table.head or self.table.row
         table.insert(line, { chars[1] .. table.concat(sections, chars[2]) .. chars[3], highlight })
-        self.marks:add_start(false, node, {
+        self.marks:add(false, node.start_row, node.start_col, {
             virt_lines = { vim.list_extend(self:indent_line(true), line) },
             virt_lines_above = above,
         })

tests/util.lua

@@ -472,8 +472,8 @@ end
 ---@private
 ---@return render.md.MarkInfo[]
 function M.actual_marks()
-    local namespace = require('render-markdown.core.ui').namespace
-    local marks = vim.api.nvim_buf_get_extmarks(0, namespace, 0, -1, { details = true })
+    local ui = require('render-markdown.core.ui')
+    local marks = vim.api.nvim_buf_get_extmarks(0, ui.ns, 0, -1, { details = true })
     ---@type render.md.MarkDetails[]
     local actual = {}
     for _, mark in ipairs(marks) do