Skip to content

[Bug]: Reset password functionality allows reuse of existing password #33435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjetpoluru opened this issue Jun 3, 2025 · 2 comments
Open
Assignees
Labels
feature-branch-bug bug that was found on a feature branch, but not yet merged in main branch needs-triage Issue needs to be triaged seedless-onboarding Any issues related to the seedless onboarding feature Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. type-bug Something isn't working

Comments

@hjetpoluru
Copy link
Contributor

hjetpoluru commented Jun 3, 2025

Describe the bug

The reset password feature permits users to set their current password as the new password during the reset process. This behavior undermines the purpose of a password reset, which is to enforce the creation of a new, secure password. Allowing the reuse of the existing password poses a potential security risk and does not align with standard password reset practices.

Expected behavior

  • When entering the password on the "Continue" screen, the button should be labeled "Continue" instead of "Save."
  • The system should validate the new password and reject it if it matches the existing password, prompting the user to create a different password.

Related PR - #33385

Screenshots/Recordings

Screen.Recording.2025-06-02.at.9.02.00.PM.mov

Steps to reproduce

  1. Navigate to the "Reset Password" under the Security & Privacy in the settings menu.
  2. Enter the "Enter password to continue"(#test007) as the "New Password"(#test007) during the reset process.
  3. Confirm the password and complete the reset process.
  4. Observe that the system accepts the current password as the new password without any error or warning.

Error messages or log output

Detection stage

On a feature branch

Version

12.18.1

Build type

None

Browser

Chrome

Operating system

Windows, MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@hjetpoluru hjetpoluru added the type-bug Something isn't working label Jun 3, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jun 3, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in Bugs by team Jun 3, 2025
@hjetpoluru hjetpoluru added seedless-onboarding Any issues related to the seedless onboarding feature Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. feature-branch-bug bug that was found on a feature branch, but not yet merged in main branch labels Jun 3, 2025
@metamaskbot metamaskbot added the needs-triage Issue needs to be triaged label Jun 3, 2025
@LeVinhGithub
Copy link

Thanks @hjetpoluru
Let me forward it to my PM

@lwin-kyaw lwin-kyaw self-assigned this Jun 4, 2025
@lwin-kyaw
Copy link
Contributor

Hi @hjetpoluru, reset password (change password) is only added in this PR, #33385.
Updated the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-branch-bug bug that was found on a feature branch, but not yet merged in main branch needs-triage Issue needs to be triaged seedless-onboarding Any issues related to the seedless onboarding feature Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. type-bug Something isn't working
Projects
Status: To be fixed
Status: To be triaged
Development

No branches or pull requests

4 participants