Skip to content

fix(snaps): Adjust SnapUIAccountSelector height #33514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Jun 6, 2025

Description

This PR adjust the size of the SnapUIAccountSelector to avoid squishing the content when the account has a label.

I also included a small fix to disable the hover background color of the AccountListItem.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Enter two SRP in the extension
  2. Use the Account Selector in Snaps UI
  3. Ensure that the content doesn't get squished

Screenshots/Recordings

Before

image
image

After

image
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner June 6, 2025 12:31
Copy link
Contributor

github-actions bot commented Jun 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jun 6, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 6, 2025

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/snaps-devs (3 files, +12 -4)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 snaps/
          • 📁 snap-ui-account-selector/
            • 📄 index.scss +8 -0
            • 📄 snap-ui-account-selector.tsx +2 -2
          • 📁 snap-ui-renderer/
            • 📁 components/
              • 📁 __snapshots__/
                • 📄 account-selector.test.ts.snap +2 -2

@metamaskbot
Copy link
Collaborator

Builds ready [6090a2d]
UI Startup Metrics (1210 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1210109713756312461338
load104794011985610831147
domContentLoaded104093511905610751141
domInteractive17136271629
firstPaint69772116042310651149
backgroundConnect84375823
firstReactRender20153642031
getState15568102130
initialActions001001
loadScripts79669094656837898
setupStore85162812
WebpackHomeuiStartup21581652257922623062518
load16651263198617818041934
domContentLoaded16581255197717717991922
domInteractive15115881441
firstPaint1696645469211289
backgroundConnect25986122952
firstReactRender15844375119315354
getState2643346215184
initialActions3110135
loadScripts16551252196617517951914
setupStore5073219223310
FirefoxBrowserifyHomeuiStartup13481149177810714131549
load1194102415559812551385
domContentLoaded1193102315559812551385
domInteractive1033537947109164
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113109122145
firstReactRender24205952329
getState85717813
initialActions001001
loadScripts1175100914949512391354
setupStore74364612
WebpackHomeuiStartup15671397196111816361791
load13561197164511214331581
domContentLoaded13561197164511214331581
domInteractive80342412486121
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22165472338
firstReactRender42344934447
getState95336928
initialActions102111
loadScripts13361180162811314181564
setupStore9512212813
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 51 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2519 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 24ms | Sum of p95 exceeds: 316ms
Sum of all benchmark exceeds: 340ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.35 KiB (0.03%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants