perf: faster cache #33518
Draft
perf: faster cache #33518
+120
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davidmurdoch
commented
Jun 6, 2025
Comment on lines
+74
to
+85
| const responseBytes = | ||
| response.status === 204 ? undefined : await response.bytes(); | ||
| const cacheEntry: CacheEntry = { | ||
| cachedResponse: responseBytes, | ||
| cachedTime: currentTime, | ||
| }; | ||
|
|
||
| await setStorageItem(cacheKey, cacheEntry); | ||
| return responseJson; | ||
| // fire and forget, no need to wait for the cache to be written | ||
| setStorageItem(cacheKey, cacheEntry); | ||
|
|
||
| // @ts-expect-error typescript's `JSON.parse` type is wrong; it does allow parsing of `Uint8Array` directly | ||
| return responseBytes ?? (JSON.parse(responseBytes) as R); |
There was a problem hiding this comment.
TODO: need to benchmark storing raw bytes vs JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Needs migration to delete all old indexedb-cached files
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist