Merge pull request Azure#6139 from sergey-shandar/sergey-signalr-bugfix

SignalR bug fix for null pointer exception

Author: cormacpayne

src/ResourceManager/SignalR/ChangeLog.md

@@ -0,0 +1,22 @@
+<!--
+    Please leave this section at the top of the change log.
+
+    Changes for the current release should go under the section titled "Current Release", and should adhere to the following format:
+
+    ## Current Release
+    * Overview of change #1
+        - Additional information about change #1
+    * Overview of change #2
+        - Additional information about change #2
+        - Additional information about change #2
+    * Overview of change #3
+    * Overview of change #4
+        - Additional information about change #4
+
+    ## YYYY.MM.DD - Version X.Y.Z (Previous Release)
+    * Overview of change #1
+        - Additional information about change #1
+-->
+## 0.1.1
+
+* `New-AzureRmSignalR` null reference bug fix.

src/ResourceManager/SignalR/Commands.SignalR/AzureRM.SignalR.psd1

@@ -12,7 +12,7 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '0.1.0'
+ModuleVersion = '0.1.1'
 
 # Supported PSEditions
 # CompatiblePSEditions = @()
@@ -51,7 +51,7 @@ CLRVersion = '4.0'
 # ProcessorArchitecture = ''
 
 # Modules that must be imported into the global environment prior to importing this module
-RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '4.6.0'; })
+RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '5.0.0'; })
 
 # Assemblies that must be loaded prior to importing this module
 RequiredAssemblies = @(
@@ -115,7 +115,7 @@ PrivateData = @{
         # IconUri = ''
 
         # ReleaseNotes of this module
-        ReleaseNotes = '* Initial command set for SignalR service'
+        ReleaseNotes = '* `New-AzureRmSignalR` null reference bug fix.'
 
 		# Prerelease string of this module
 		Prerelease = 'preview'

src/ResourceManager/SignalR/Commands.SignalR/Properties/Resources.Designer.cs

@@ -120,6 +120,9 @@
   <data name="DefaultResourceGroupKey" xml:space="preserve">
     <value>Default Resource Group</value>
   </data>
+  <data name="NoSubscriptionInContext" xml:space="preserve">
+    <value>No subscription found in the context.  Please ensure that the credentials you provided are authorized to access an Azure subscription, then run Connect-AzureRmAccount to login.</value>
+  </data>
   <data name="ParameterSetError" xml:space="preserve">
     <value>The parameter set could not be determined from the provided parameters. Please check the documentation for appropriate parameters, and report this issue at https://github.com/azure/azure-powershell/issues</value>
   </data>

src/ResourceManager/SignalR/Commands.SignalR/Properties/Resources.resx

@@ -15,7 +15,9 @@
 using Microsoft.Azure.Commands.Common.Authentication;
 using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
 using Microsoft.Azure.Commands.Common.Strategies;
+using Microsoft.Azure.Commands.SignalR.Properties;
 using Microsoft.Rest;
+using System;
 
 namespace Microsoft.Azure.Commands.SignalR.Strategies
 {
@@ -27,6 +29,11 @@ sealed class Client : IClient
 
         public Client(IAzureContext context)
         {
+            if (context == null)
+            {
+                throw new ApplicationException(Resources.NoSubscriptionInContext);
+            }
+
             Context = context;
             SubscriptionId = Context.Subscription.Id;
         }

src/ResourceManager/SignalR/Commands.SignalR/Strategies/Client.cs

@@ -25,6 +25,11 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Common.Authenticat
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.ServiceManagement.Common", "..\..\ServiceManagement\Common\Commands.ServiceManagement.Common\Commands.ServiceManagement.Common.csproj", "{CFF09E81-1E31-444E-B4D4-A21E946C29E2}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{64DE12BE-23D1-4D48-8798-4F26BA697254}"
+	ProjectSection(SolutionItems) = preProject
+		ChangeLog.md = ChangeLog.md
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU