Skip to content

Commit 0f13f36

Browse files
committed
Enabled 2 more Sql tests in netcore
1 parent 1af94b3 commit 0f13f36

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/Common.ps1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,8 @@ Gets the parameters for import/export tests
507507
function Get-SqlDatabaseImportExportTestEnvironmentParameters ($testSuffix)
508508
{
509509
$databaseName = "sql-ie-cmdlet-db" + $testSuffix;
510-
$password = [Microsoft.Azure.Test.TestUtilities]::GenerateName("IEp@ssw0rd");
510+
# TODO: Remove "CallSite.Target" when re-recording ImportExportTests
511+
$password = [Microsoft.Rest.ClientRuntime.Azure.TestFramework.TestUtilities]::GenerateName("IEp@ssw0rd", "CallSite.Target");
511512
#Fake storage account data. Used for playback mode
512513
$exportBacpacUri = "http://test.blob.core.windows.net/bacpacs"
513514
$importBacpacUri = "http://test.blob.core.windows.net/bacpacs/test.bacpac"

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/ImportExportTests.cs

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,20 @@ public ImportExportTests(ITestOutputHelper output) : base(output)
2525
{
2626
}
2727

28-
#if NETSTANDARD
29-
[Fact(Skip = "Cannot run Get-SqlDatabaseImportExportTestEnvironmentParameters -> GetName due to version differences")]
30-
[Trait(Category.RunType, Category.DesktopOnly)]
31-
#else
28+
3229
[Fact]
33-
#endif
3430
[Trait(Category.AcceptanceType, Category.CheckIn)]
31+
[Trait(Category.Sql, "Needs to be re-recorded")]
32+
// TODO: Remove "CallSite.Target" from Get-SqlDatabaseImportExportTestEnvironmentParameters in GetName when re-recording
3533
public void TestExportDatabase()
3634
{
3735
RunPowerShellTest("Test-ExportDatabase");
3836
}
3937

40-
#if NETSTANDARD
41-
[Fact(Skip = "Cannot run Get-SqlDatabaseImportExportTestEnvironmentParameters -> GetName due to version differences")]
42-
[Trait(Category.RunType, Category.DesktopOnly)]
43-
#else
4438
[Fact]
45-
#endif
4639
[Trait(Category.AcceptanceType, Category.CheckIn)]
40+
[Trait(Category.Sql, "Needs to be re-recorded")]
41+
// TODO: Remove "CallSite.Target" from Get-SqlDatabaseImportExportTestEnvironmentParameters in GetName when re-recording
4742
public void TestImportDatabase()
4843
{
4944
RunPowerShellTest("Test-ImportDatabase");

0 commit comments

Comments
 (0)