Restore resource group parameter position and add unit count parameter on creation

Author: allxiao

src/ResourceManager/SignalR/Commands.SignalR/Cmdlets/GetAzureRmSignalR.cs

@@ -25,7 +25,7 @@ namespace Microsoft.Azure.Commands.SignalR.Cmdlets
     [OutputType(typeof(PSSignalRResource))]
     public class GetAzureRmSignalR : SignalRCmdletBase, IWithResourceId
     {
-        [Parameter(
+        [Parameter(Position = 0,
             Mandatory = false,
             ParameterSetName = ListSignalRServiceParameterSet,
             HelpMessage = "The resource group name.")]

src/ResourceManager/SignalR/Commands.SignalR/Cmdlets/GetAzureRmSignalRKey.cs

@@ -25,7 +25,7 @@ namespace Microsoft.Azure.Commands.SignalR.Cmdlets
     [OutputType(typeof(PSSignalRKeys))]
     public class GetAzureRmSignalRKey : SignalRCmdletBase, IWithInputObject, IWithResourceId
     {
-        [Parameter(
+        [Parameter(Position = 0,
             Mandatory = false,
             ParameterSetName = ResourceGroupParameterSet,
             HelpMessage = "The resource group name. The default one will be used if not specified.")]

src/ResourceManager/SignalR/Commands.SignalR/Cmdlets/NewAzureRmSignalR.cs

@@ -31,7 +31,7 @@ public sealed class NewAzureRmSignalR : SignalRCmdletBase
     {
         private const string DefaultSku = "Basic_DS2";
 
-        [Parameter(
+        [Parameter(Position = 0,
             Mandatory = false,
             HelpMessage = "The resource group name. The default one will be used if not specified.")]
         [ValidateNotNullOrEmpty()]
@@ -55,9 +55,16 @@ public sealed class NewAzureRmSignalR : SignalRCmdletBase
         [Parameter(
             Mandatory = false,
             HelpMessage = "The SignalR service SKU.")]
-        [PSArgumentCompleter("Basic_DS2")]
+        [PSArgumentCompleter("Free_DS2", "Basic_DS2")]
         public string Sku { get; set; } = DefaultSku;
 
+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "The SignalR service unit count, from 1 to 10. Default to 1.")]
+        [PSArgumentCompleter("1", "2", "3", "4", "5", "6", "7", "8", "9", "10")]
+        [ValidateRange(1, 10)]
+        public int UnitCount { get; set; } = 1;
+
         [Parameter(
             Mandatory = false,
             HelpMessage = "The tags for the SignalR service.")]
@@ -97,22 +104,18 @@ public Parameters(NewAzureRmSignalR cmdlet)
 
             public Task<ResourceConfig<SignalRResource>> CreateConfigAsync()
             {
+                _cmdlet.ResolveResourceGroupName(required: false);
                 _cmdlet.ResourceGroupName = _cmdlet.ResourceGroupName ?? _cmdlet.Name;
-                _cmdlet.ResolveResourceGroupName();
 
                 var resourceGroup = ResourceGroupStrategy.CreateResourceGroupConfig(
                     _cmdlet.ResourceGroupName);
 
                 var result = SignalRStrategy.Strategy.CreateResourceConfig(
                     resourceGroup: resourceGroup,
-                    // The SignalR service accepts only lower case characters. It's a known bug.
-                    // TODO: remove ".ToLower()" as soon as the problem is fixed in SignalR server.
-                    // See also 
-                    // https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource
-                    name: _cmdlet.Name.ToLower(),
+                    name: _cmdlet.Name,
                     createModel: engine => new SignalRResource(
                         tags: _cmdlet.Tag,
-                        sku: new ResourceSku(_cmdlet.Sku, capacity: 1), // we only allow capacity 1 in public preview, this may be a parameter in future.
+                        sku: new ResourceSku(_cmdlet.Sku, capacity: _cmdlet.UnitCount),
                         hostNamePrefix: null /* _cmdlet.Name*/)); // hostNamePrefix is just a placeholder and ignored in the resource provider.
 
                 return Task.FromResult(result);

src/ResourceManager/SignalR/Commands.SignalR/Cmdlets/NewAzureRmSignalRKey.cs

@@ -26,7 +26,7 @@ namespace Microsoft.Azure.Commands.SignalR.Cmdlets
     [OutputType(typeof(bool))]
     public class NewAzureRmSignalRKey : SignalRCmdletBase, IWithInputObject, IWithResourceId
     {
-        [Parameter(
+        [Parameter(Position = 0,
             Mandatory = false,
             ParameterSetName = ResourceGroupParameterSet,
             HelpMessage = "The resource group name. The default one will be used if not specified.")]

src/ResourceManager/SignalR/Commands.SignalR/Cmdlets/RemoveAzureRmSignalR.cs

@@ -25,7 +25,7 @@ namespace Microsoft.Azure.Commands.SignalR.Cmdlets
     [OutputType(typeof(bool))]
     public class RemoveAzureRmSignalR : SignalRCmdletBase, IWithInputObject, IWithResourceId
     {
-        [Parameter(
+        [Parameter(Position = 0,
             Mandatory = false,
             ParameterSetName = ResourceGroupParameterSet,
             HelpMessage = "The resource group name. The default one will be used if not specified.")]

src/ResourceManager/SignalR/Commands.SignalR/help/New-AzureRmSignalR.md

@@ -14,7 +14,7 @@ Create a SignalR service.
 
 ```
 New-AzureRmSignalR [[-ResourceGroupName] <String>] [-Name] <String> [[-Location] <String>] [-Sku <String>]
- [-Tag <System.Collections.Generic.IDictionary`2[System.String,System.String]>] [-AsJob]
+ [-UnitCount <Int32>] [-Tag <System.Collections.Generic.IDictionary`2[System.String,System.String]>] [-AsJob]
  [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
@@ -145,6 +145,21 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
+### -UnitCount
+The SignalR service unit count, from 1 to 10. Default to 1.
+
+```yaml
+Type: Int32
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: 1
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -Confirm
 Prompts you for confirmation before running the cmdlet.