Skip to content

Commit 99b912c

Browse files
cormacpaynecormacpayne
authored
Merge pull request Azure#5805 from djyou/preview
[ACR] Decouple reliance on Commands.Resources.Rest
2 parents bf89236 + 7efbaa1 commit 99b912c

36 files changed

+3516
-158899
lines changed

‎src/ResourceManager/ContainerRegistry/AzureRM.ContainerRegistry.psd1

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,7 @@ CLRVersion = '4.0'
5454
RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '4.5.0'; })
5555

5656
# Assemblies that must be loaded prior to importing this module
57-
RequiredAssemblies = '.\Microsoft.Azure.Management.ContainerRegistry.dll',
58-
'.\Microsoft.Azure.Management.ResourceManager.dll',
59-
'.\Microsoft.Azure.Management.Storage.dll',
60-
'.\Microsoft.Azure.Commands.ResourceManager.Cmdlets.dll'
57+
RequiredAssemblies = '.\Microsoft.Azure.Management.ContainerRegistry.dll'
6158

6259
# Script files (.ps1) that are run in the caller's environment prior to importing this module.
6360
# ScriptsToProcess = @()
@@ -75,7 +72,8 @@ NestedModules = @('.\Microsoft.Azure.Commands.ContainerRegistry.dll')
7572
FunctionsToExport = @()
7673

7774
# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
78-
CmdletsToExport = 'New-AzureRmContainerRegistry', 'Get-AzureRmContainerRegistry',
75+
CmdletsToExport = 'New-AzureRmContainerRegistry',
76+
'Get-AzureRmContainerRegistry',
7977
'Update-AzureRmContainerRegistry',
8078
'Remove-AzureRmContainerRegistry',
8179
'Get-AzureRmContainerRegistryCredential',

‎src/ResourceManager/ContainerRegistry/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Current Release
21+
* Decouple reliance on Commands.Resources.Rest and ARM/Storage SDKs.
2122

2223
## Version 1.0.3
2324
* Fix issue with Default Resource Group in CloudShell

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/Commands.ContainerRegistry.Test.csproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,6 @@
5959
<HintPath>..\..\..\packages\Microsoft.Azure.Management.ResourceManager.1.6.0-preview\lib\net452\Microsoft.Azure.Management.ResourceManager.dll</HintPath>
6060
<Private>True</Private>
6161
</Reference>
62-
<Reference Include="Microsoft.Azure.Management.Storage, Version=6.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
63-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Storage.6.5.0-preview\lib\net452\Microsoft.Azure.Management.Storage.dll</HintPath>
64-
</Reference>
6562
<Reference Include="Microsoft.Azure.Test.Framework">
6663
<SpecificVersion>False</SpecificVersion>
6764
<HintPath>..\..\..\packages\Microsoft.Azure.Test.Framework.1.0.6179.26854-prerelease\lib\net45\Microsoft.Azure.Test.Framework.dll</HintPath>

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/ScenarioTests/TestController.cs

Lines changed: 11 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -12,32 +12,26 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15-
using System;
16-
using System.IO;
17-
using System.Linq;
15+
using Microsoft.Azure.Commands.Common.Authentication;
1816
using Microsoft.Azure.Management.ContainerRegistry;
19-
using Microsoft.Azure.Management.Storage;
20-
using Microsoft.Azure.Management.ResourceManager;
2117
using Microsoft.Azure.Test.HttpRecorder;
22-
using Microsoft.Azure.Commands.Common.Authentication;
2318
using Microsoft.Rest.ClientRuntime.Azure.TestFramework;
2419
using Microsoft.WindowsAzure.Commands.ScenarioTest;
20+
using System;
21+
using System.Collections.Generic;
22+
using System.IO;
23+
using System.Linq;
24+
using InternalResourceManagementClient = Microsoft.Azure.Management.Internal.Resources.ResourceManagementClient;
25+
using ResourceManagementClient = Microsoft.Azure.Management.ResourceManager.ResourceManagementClient;
2526
using TestEnvironmentFactory = Microsoft.Rest.ClientRuntime.Azure.TestFramework.TestEnvironmentFactory;
2627
using TestUtilities = Microsoft.Rest.ClientRuntime.Azure.TestFramework.TestUtilities;
27-
using System.Collections.Generic;
2828

2929
namespace Microsoft.Azure.Commands.ContainerRegistry.Test.ScenarioTests
3030
{
3131
public class TestController
3232
{
3333
private EnvironmentSetupHelper helper;
3434

35-
public ContainerRegistryManagementClient ContainerRegistryClient { get; private set; }
36-
37-
public StorageManagementClient StorageClient { get; private set; }
38-
39-
public ResourceManagementClient ResourceClient { get; private set; }
40-
4135
public TestController()
4236
{
4337
helper = new EnvironmentSetupHelper();
@@ -53,10 +47,10 @@ public static TestController NewInstance
5347

5448
private void SetupManagementClients(MockContext context)
5549
{
56-
ContainerRegistryClient = GetContainerRegistryManagementClient(context);
57-
StorageClient = GetStorageManagementClient(context);
58-
ResourceClient = GetResourceManagementClient(context);
59-
helper.SetupManagementClients(ContainerRegistryClient, StorageClient, ResourceClient);
50+
helper.SetupManagementClients(
51+
context.GetServiceClient<ContainerRegistryManagementClient>(TestEnvironmentFactory.GetTestEnvironment()),
52+
context.GetServiceClient<ResourceManagementClient>(TestEnvironmentFactory.GetTestEnvironment()),
53+
context.GetServiceClient<InternalResourceManagementClient>(TestEnvironmentFactory.GetTestEnvironment()));
6054
}
6155

6256
public void RunPowerShellTest(params string[] scripts)
@@ -68,7 +62,6 @@ public void RunPowerShellTest(params string[] scripts)
6862
d.Add("Microsoft.Resources", null);
6963
d.Add("Microsoft.Features", null);
7064
d.Add("Microsoft.Authorization", null);
71-
d.Add("Microsoft.Compute", null);
7265
var providersToIgnore = new Dictionary<string, string>();
7366
providersToIgnore.Add("Microsoft.Azure.Management.Resources.ResourceManagementClient", "2016-02-01");
7467
HttpMockServer.Matcher = new PermissiveRecordMatcherWithApiExclusion(true, d, providersToIgnore);
@@ -94,20 +87,5 @@ public void RunPowerShellTest(params string[] scripts)
9487
}
9588
}
9689
}
97-
98-
private ContainerRegistryManagementClient GetContainerRegistryManagementClient(MockContext context)
99-
{
100-
return context.GetServiceClient<ContainerRegistryManagementClient>(TestEnvironmentFactory.GetTestEnvironment());
101-
}
102-
103-
private StorageManagementClient GetStorageManagementClient(MockContext context)
104-
{
105-
return context.GetServiceClient<StorageManagementClient>(TestEnvironmentFactory.GetTestEnvironment());
106-
}
107-
108-
private ResourceManagementClient GetResourceManagementClient(MockContext context)
109-
{
110-
return context.GetServiceClient<ResourceManagementClient>(TestEnvironmentFactory.GetTestEnvironment());
111-
}
11290
}
11391
}

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/SessionRecords/Microsoft.Azure.Commands.ContainerRegistry.Test.ScenarioTests.ContainerRegistryTests/TestAzureContainerRegistry.json

Lines changed: 1170 additions & 154302 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/SessionRecords/Microsoft.Azure.Commands.ContainerRegistry.Test.ScenarioTests.ContainerRegistryTests/TestAzureContainerRegistryCredential.json

Lines changed: 717 additions & 1257 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/SessionRecords/Microsoft.Azure.Commands.ContainerRegistry.Test.ScenarioTests.ContainerRegistryTests/TestAzureContainerRegistryNameAvailability.json

Lines changed: 31 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"Entries": [
33
{
4-
"RequestUri": "/subscriptions/474240ee-c2a4-4373-bc0d-bd2e3dba4714/providers/Microsoft.ContainerRegistry/checkNameAvailability?api-version=2017-10-01",
5-
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvNDc0MjQwZWUtYzJhNC00MzczLWJjMGQtYmQyZTNkYmE0NzE0L3Byb3ZpZGVycy9NaWNyb3NvZnQuQ29udGFpbmVyUmVnaXN0cnkvY2hlY2tOYW1lQXZhaWxhYmlsaXR5P2FwaS12ZXJzaW9uPTIwMTctMTAtMDE=",
4+
"RequestUri": "/subscriptions/84c559c6-30a0-417c-ba06-8a2253b388c3/providers/Microsoft.ContainerRegistry/checkNameAvailability?api-version=2017-10-01",
5+
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvODRjNTU5YzYtMzBhMC00MTdjLWJhMDYtOGEyMjUzYjM4OGMzL3Byb3ZpZGVycy9NaWNyb3NvZnQuQ29udGFpbmVyUmVnaXN0cnkvY2hlY2tOYW1lQXZhaWxhYmlsaXR5P2FwaS12ZXJzaW9uPTIwMTctMTAtMDE=",
66
"RequestMethod": "POST",
7-
"RequestBody": "{\r\n \"name\": \"regps3697\",\r\n \"type\": \"Microsoft.ContainerRegistry/registries\"\r\n}",
7+
"RequestBody": "{\r\n \"name\": \"regps3538\",\r\n \"type\": \"Microsoft.ContainerRegistry/registries\"\r\n}",
88
"RequestHeaders": {
99
"Content-Type": [
1010
"application/json; charset=utf-8"
@@ -13,15 +13,15 @@
1313
"80"
1414
],
1515
"x-ms-client-request-id": [
16-
"9f170182-bc94-48d0-a0fc-ee2ecc6ae9e2"
16+
"5f388704-861d-4277-af82-ae3d3243ff02"
1717
],
1818
"accept-language": [
1919
"en-US"
2020
],
2121
"User-Agent": [
22-
"FxVersion/4.7.2117.0",
23-
"OSName/WindowsServer2016Datacenter",
24-
"OSVersion/6.3.14393",
22+
"FxVersion/4.7.2633.0",
23+
"OSName/Windows10Enterprise",
24+
"OSVersion/6.3.16299",
2525
"Microsoft.Azure.Management.ContainerRegistry.ContainerRegistryManagementClient/2.0.0.0"
2626
]
2727
},
@@ -43,22 +43,25 @@
4343
"max-age=31536000; includeSubDomains"
4444
],
4545
"x-ms-ratelimit-remaining-subscription-reads": [
46-
"14998"
46+
"14969"
4747
],
4848
"x-ms-request-id": [
49-
"d2d34a49-83d8-434c-bddb-cd0d3412fae8"
49+
"31caa2ad-5c45-406d-bea4-36e4cd898149"
5050
],
5151
"x-ms-correlation-request-id": [
52-
"d2d34a49-83d8-434c-bddb-cd0d3412fae8"
52+
"31caa2ad-5c45-406d-bea4-36e4cd898149"
5353
],
5454
"x-ms-routing-request-id": [
55-
"WESTUS2:20171120T191819Z:d2d34a49-83d8-434c-bddb-cd0d3412fae8"
55+
"WESTUS2:20180326T235648Z:31caa2ad-5c45-406d-bea4-36e4cd898149"
56+
],
57+
"X-Content-Type-Options": [
58+
"nosniff"
5659
],
5760
"Cache-Control": [
5861
"no-cache"
5962
],
6063
"Date": [
61-
"Mon, 20 Nov 2017 19:18:19 GMT"
64+
"Mon, 26 Mar 2018 23:56:47 GMT"
6265
],
6366
"Server": [
6467
"Microsoft-HTTPAPI/2.0"
@@ -67,8 +70,8 @@
6770
"StatusCode": 200
6871
},
6972
{
70-
"RequestUri": "/subscriptions/474240ee-c2a4-4373-bc0d-bd2e3dba4714/providers/Microsoft.ContainerRegistry/checkNameAvailability?api-version=2017-10-01",
71-
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvNDc0MjQwZWUtYzJhNC00MzczLWJjMGQtYmQyZTNkYmE0NzE0L3Byb3ZpZGVycy9NaWNyb3NvZnQuQ29udGFpbmVyUmVnaXN0cnkvY2hlY2tOYW1lQXZhaWxhYmlsaXR5P2FwaS12ZXJzaW9uPTIwMTctMTAtMDE=",
73+
"RequestUri": "/subscriptions/84c559c6-30a0-417c-ba06-8a2253b388c3/providers/Microsoft.ContainerRegistry/checkNameAvailability?api-version=2017-10-01",
74+
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvODRjNTU5YzYtMzBhMC00MTdjLWJhMDYtOGEyMjUzYjM4OGMzL3Byb3ZpZGVycy9NaWNyb3NvZnQuQ29udGFpbmVyUmVnaXN0cnkvY2hlY2tOYW1lQXZhaWxhYmlsaXR5P2FwaS12ZXJzaW9uPTIwMTctMTAtMDE=",
7275
"RequestMethod": "POST",
7376
"RequestBody": "{\r\n \"name\": \"Microsoft\",\r\n \"type\": \"Microsoft.ContainerRegistry/registries\"\r\n}",
7477
"RequestHeaders": {
@@ -79,15 +82,15 @@
7982
"80"
8083
],
8184
"x-ms-client-request-id": [
82-
"187d33e7-7bf5-4044-ad13-d97c5b9879f0"
85+
"62d7703b-35b5-4557-9d8f-ae7a6656dfe9"
8386
],
8487
"accept-language": [
8588
"en-US"
8689
],
8790
"User-Agent": [
88-
"FxVersion/4.7.2117.0",
89-
"OSName/WindowsServer2016Datacenter",
90-
"OSVersion/6.3.14393",
91+
"FxVersion/4.7.2633.0",
92+
"OSName/Windows10Enterprise",
93+
"OSVersion/6.3.16299",
9194
"Microsoft.Azure.Management.ContainerRegistry.ContainerRegistryManagementClient/2.0.0.0"
9295
]
9396
},
@@ -109,22 +112,25 @@
109112
"max-age=31536000; includeSubDomains"
110113
],
111114
"x-ms-ratelimit-remaining-subscription-reads": [
112-
"14997"
115+
"14968"
113116
],
114117
"x-ms-request-id": [
115-
"87de9584-8d5e-4d50-9720-b9847755c8b4"
118+
"6ff77e99-bf2e-4d84-82d9-566cb990b01a"
116119
],
117120
"x-ms-correlation-request-id": [
118-
"87de9584-8d5e-4d50-9720-b9847755c8b4"
121+
"6ff77e99-bf2e-4d84-82d9-566cb990b01a"
119122
],
120123
"x-ms-routing-request-id": [
121-
"WESTUS2:20171120T191819Z:87de9584-8d5e-4d50-9720-b9847755c8b4"
124+
"WESTUS2:20180326T235648Z:6ff77e99-bf2e-4d84-82d9-566cb990b01a"
125+
],
126+
"X-Content-Type-Options": [
127+
"nosniff"
122128
],
123129
"Cache-Control": [
124130
"no-cache"
125131
],
126132
"Date": [
127-
"Mon, 20 Nov 2017 19:18:19 GMT"
133+
"Mon, 26 Mar 2018 23:56:47 GMT"
128134
],
129135
"Server": [
130136
"Microsoft-HTTPAPI/2.0"
@@ -135,10 +141,10 @@
135141
],
136142
"Names": {
137143
"Test-AzureContainerRegistryNameAvailability": [
138-
"ps3697"
144+
"ps3538"
139145
]
140146
},
141147
"Variables": {
142-
"SubscriptionId": "474240ee-c2a4-4373-bc0d-bd2e3dba4714"
148+
"SubscriptionId": "84c559c6-30a0-417c-ba06-8a2253b388c3"
143149
}
144150
}

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/SessionRecords/Microsoft.Azure.Commands.ContainerRegistry.Test.ScenarioTests.ContainerRegistryTests/TestAzureContainerRegistryReplication.json

Lines changed: 637 additions & 1504 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/SessionRecords/Microsoft.Azure.Commands.ContainerRegistry.Test.ScenarioTests.ContainerRegistryTests/TestAzureContainerRegistryWebhook.json

Lines changed: 828 additions & 1656 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry.Test/packages.config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
<package id="Microsoft.Azure.Common.Dependencies" version="1.0.0" targetFramework="net45" />
66
<package id="Microsoft.Azure.Management.ContainerRegistry" version="2.0.0" targetFramework="net452" />
77
<package id="Microsoft.Azure.Management.ResourceManager" version="1.6.0-preview" targetFramework="net452" />
8-
<package id="Microsoft.Azure.Management.Storage" version="6.5.0-preview" targetFramework="net452" />
98
<package id="Microsoft.Azure.Test.Framework" version="1.0.6179.26854-prerelease" targetFramework="net45" />
109
<package id="Microsoft.Azure.Test.HttpRecorder" version="1.7.0" targetFramework="net45" />
1110
<package id="Microsoft.Bcl" version="1.1.10" targetFramework="net45" />

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Commands.ContainerRegistry.csproj

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,6 @@
5151
<Reference Include="Microsoft.Azure.Management.ContainerRegistry, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
5252
<HintPath>..\..\..\packages\Microsoft.Azure.Management.ContainerRegistry.2.0.0\lib\net452\Microsoft.Azure.Management.ContainerRegistry.dll</HintPath>
5353
</Reference>
54-
<Reference Include="Microsoft.Azure.Management.ResourceManager, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
55-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.ResourceManager.1.6.0-preview\lib\net452\Microsoft.Azure.Management.ResourceManager.dll</HintPath>
56-
<Private>True</Private>
57-
</Reference>
58-
<Reference Include="Microsoft.Azure.Management.Storage, Version=6.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
59-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Storage.6.5.0-preview\lib\net452\Microsoft.Azure.Management.Storage.dll</HintPath>
60-
</Reference>
6154
<Reference Include="System.Management.Automation, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL" />
6255
</ItemGroup>
6356
<ItemGroup>
@@ -118,10 +111,6 @@
118111
<Project>{3819d8a7-c62c-4c47-8ddd-0332d9ce1252}</Project>
119112
<Name>Commands.ResourceManager.Common</Name>
120113
</ProjectReference>
121-
<ProjectReference Include="..\..\Resources\Commands.ResourceManager\Cmdlets\Commands.Resources.Rest.csproj">
122-
<Project>{8058d403-06e3-4bed-8924-d166ce303961}</Project>
123-
<Name>Commands.Resources.Rest</Name>
124-
</ProjectReference>
125114
</ItemGroup>
126115
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
127116
<Import Project="..\..\..\..\tools\Common.Dependencies.targets" />

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Commands/GetAzureContainerRegistry.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15+
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
1516
using System.Collections.Generic;
1617
using System.Management.Automation;
1718

@@ -23,6 +24,7 @@ public class GetAzureContainerRegistry : ContainerRegistryCmdletBase
2324
{
2425
[Parameter(Position = 0, Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ListRegistriesParameterSet, HelpMessage = "Resource Group Name.")]
2526
[Parameter(Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RegistryNameParameterSet, HelpMessage = "Resource Group Name.")]
27+
[ResourceGroupCompleter()]
2628
[ValidateNotNullOrEmpty]
2729
public string ResourceGroupName { get; set; }
2830

@@ -50,7 +52,7 @@ public override void ExecuteCmdlet()
5052
if (MyInvocation.BoundParameters.ContainsKey("ResourceId") || !string.IsNullOrWhiteSpace(ResourceId))
5153
{
5254
string resourceGroup, registryName, childResourceName;
53-
if(!ConversionUtilities.TryParseRegistryRelatedResourceId(ResourceId, out resourceGroup, out registryName, out childResourceName))
55+
if (!ConversionUtilities.TryParseRegistryRelatedResourceId(ResourceId, out resourceGroup, out registryName, out childResourceName))
5456
{
5557
WriteInvalidResourceIdError(InvalidRegistryResourceIdErrorMessage);
5658
return;
@@ -81,7 +83,7 @@ private void ListRegistry()
8183

8284
if (IncludeDetail)
8385
{
84-
foreach(var psr in psRegistries)
86+
foreach (var psr in psRegistries)
8587
{
8688
SetRegistryDetials(psr);
8789
}
@@ -91,7 +93,7 @@ private void ListRegistry()
9193

9294
private void SetRegistryDetials(PSContainerRegistry registry)
9395
{
94-
if(!string.IsNullOrEmpty(registry.ResourceGroupName) && !string.IsNullOrEmpty(registry.Name))
96+
if (!string.IsNullOrEmpty(registry.ResourceGroupName) && !string.IsNullOrEmpty(registry.Name))
9597
{
9698
registry.Usages = RegistryClient.ListRegistryUsage(registry.ResourceGroupName, registry.Name)?.Value;
9799
}

‎src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Commands/GetAzureContainerRegistryCredential.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ namespace Microsoft.Azure.Commands.ContainerRegistry
2222
public class GetAzureContainerRegistryCredential : ContainerRegistryCmdletBase
2323
{
2424
[Parameter(Position = 0, Mandatory = true, ParameterSetName = NameResourceGroupParameterSet, HelpMessage = "Resource Group Name.")]
25+
[ResourceGroupCompleter()]
2526
[ValidateNotNullOrEmpty]
2627
public string ResourceGroupName { get; set; }
2728

@@ -49,7 +50,7 @@ public override void ExecuteCmdlet()
4950
else if (MyInvocation.BoundParameters.ContainsKey("ResourceId") || !string.IsNullOrWhiteSpace(ResourceId))
5051
{
5152
string resourceGroup, registryName, childResourceName;
52-
if(!ConversionUtilities.TryParseRegistryRelatedResourceId(ResourceId, out resourceGroup, out registryName, out childResourceName))
53+
if (!ConversionUtilities.TryParseRegistryRelatedResourceId(ResourceId, out resourceGroup, out registryName, out childResourceName))
5354
{
5455
WriteInvalidResourceIdError(InvalidRegistryResourceIdErrorMessage);
5556
return;

0 commit comments

Comments
 (0)