Skip to content

Commit dbae030

Browse files
committed
Fix review comments
1 parent 14f0276 commit dbae030

File tree

2 files changed

+18
-9
lines changed

2 files changed

+18
-9
lines changed

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/ExpressRouteCircuitTests.ps1

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ function Test-ExpressRouteRouteFilters
4242
$resourceGroup = New-AzureRmResourceGroup -Name $rgname -Location $location
4343

4444
# Create the route filter
45-
$filter = New-AzureRmRouteFilter -Name $filterName -ResourceGroupName $rgname -Location $location -Force
45+
$job = New-AzureRmRouteFilter -Name $filterName -ResourceGroupName $rgname -Location $location -Force -AsJob
46+
$job | Wait-Job
47+
$filter = $job | Receive-Job
4648

4749
#verification
4850
Assert-AreEqual $rgName $filter.ResourceGroupName
@@ -53,7 +55,9 @@ function Test-ExpressRouteRouteFilters
5355
$rule = New-AzureRmRouteFilterRuleConfig -Name $ruleName -Access Allow -RouteFilterRuleType Community -CommunityList "12076:5010" -Force
5456
$filter = Get-AzureRmRouteFilter -Name filter -ResourceGroupName filter
5557
$filter.Rules.Add($rule)
56-
$filter = Set-AzureRmRouteFilter -RouteFilter $filter -Force
58+
$job = Set-AzureRmRouteFilter -RouteFilter $filter -Force -AsJob
59+
$job | Wait-Job
60+
$filter = $job | Receive-Job
5761

5862
#verification
5963
Assert-AreEqual $rgName $filter.ResourceGroupName
@@ -97,7 +101,9 @@ function Test-ExpressRouteCircuitStageCRUD
97101
$resourceGroup = New-AzureRmResourceGroup -Name $rgname -Location $rglocation
98102

99103
# Create the ExpressRouteCircuit
100-
$circuit = New-AzureRmExpressRouteCircuit -Name $circuitName -Location $location -ResourceGroupName $rgname -SkuTier Standard -SkuFamily MeteredData -ServiceProviderName "equinix" -PeeringLocation "Silicon Valley" -BandwidthInMbps 500 -AllowClassicOperations $true;
104+
$job = New-AzureRmExpressRouteCircuit -Name $circuitName -Location $location -ResourceGroupName $rgname -SkuTier Standard -SkuFamily MeteredData -ServiceProviderName "equinix" -PeeringLocation "Silicon Valley" -BandwidthInMbps 500 -AllowClassicOperations $true -AsJob
105+
$job | Wait-Job
106+
$circuit = $job | Receive-Job
101107

102108
$circuit = Get-AzureRmExpressRouteCircuit -Name $circuitName -ResourceGroupName $rgname
103109
# set
@@ -106,13 +112,15 @@ function Test-ExpressRouteCircuitStageCRUD
106112

107113
$actual = Get-AzureRmExpressRouteCircuitStats -ResourceGroupName $rgname -ExpressRouteCircuitName $circuit.Name
108114
Assert-AreEqual $actual.PrimaryBytesIn 0
109-
110115

111116
#move
112-
Move-AzureRmExpressRouteCircuit -Name $circuitName -ResourceGroupName $rgname -Location $location -ServiceKey $circuit.ServiceKey -Force
113-
117+
$job = Move-AzureRmExpressRouteCircuit -Name $circuitName -ResourceGroupName $rgname -Location $location -ServiceKey $circuit.ServiceKey -Force -AsJob
118+
$job | Wait-Job
119+
114120
# Delete Circuit
115-
$delete = Remove-AzureRmExpressRouteCircuit -ResourceGroupName $rgname -name $circuitName -PassThru -Force
121+
$job = Remove-AzureRmExpressRouteCircuit -ResourceGroupName $rgname -name $circuitName -PassThru -Force -AsJob
122+
$job | Wait-Job
123+
$delete = $job | Receive-Job
116124
Assert-AreEqual true $delete
117125

118126
$list = Get-AzureRmExpressRouteCircuit -ResourceGroupName $rgname
@@ -177,7 +185,9 @@ function Test-ExpressRouteCircuitCRUD
177185
$getCircuit.Sku.Tier = "Premium"
178186
$getCircuit.Sku.Family = "UnlimitedData"
179187

180-
$getCircuit = Set-AzureRmExpressRouteCircuit -ExpressRouteCircuit $getCircuit
188+
$job = Set-AzureRmExpressRouteCircuit -ExpressRouteCircuit $getCircuit -AsJob
189+
$job | Wait-Job
190+
$getCircuit = $job | Receive-Job
181191
Assert-AreEqual $rgName $getCircuit.ResourceGroupName
182192
Assert-AreEqual $circuitName $getCircuit.Name
183193
Assert-NotNull $getCircuit.Location

src/ResourceManager/Network/Commands.Network/packages.config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<package id="AutoMapper" version="6.0.2" targetFramework="net452" />
44
<package id="Microsoft.Azure.KeyVault.Core" version="1.0.0" targetFramework="net45" />
55
<package id="Microsoft.Azure.Management.Network" version="17.0.0-preview" targetFramework="net452" />
6-
<package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" />
76
<package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.10" targetFramework="net452" />
87
<package id="Newtonsoft.Json" version="6.0.8" targetFramework="net452" />
98
</packages>

0 commit comments

Comments
 (0)