Skip to content

Commit f4feab9

Browse files
authored
[NFC][KeyInstr] Add (LLVM_)EXPERIMENTAL_KEY_INSTRUCTIONS (cmake/)definition (llvm#131344)
Key Instructions will start development behind a compile time flag to avoid passing on the increased memory usage to all debug builds. We're working on improving DILocation memory characteristics simultaneously; once that work lands we can remove `EXPERIMENTAL_KEY_INSTRUCTIONS`. This patch doesn't add any code, it's just so we can get the SIE buildbot building with the new option right away.
1 parent e57cd10 commit f4feab9

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

llvm/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -545,6 +545,9 @@ set(LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING "DISABLED" CACHE STRING
545545
"Enhance Debugify's line number coverage tracking; enabling this is ABI-breaking. Can be DISABLED, or COVERAGE.")
546546
set_property(CACHE LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING PROPERTY STRINGS DISABLED COVERAGE)
547547

548+
option(LLVM_EXPERIMENTAL_KEY_INSTRUCTIONS
549+
"Add additional fields to DILocations to support Key Instructions" OFF)
550+
548551
set(WINDOWS_PREFER_FORWARD_SLASH_DEFAULT OFF)
549552
if (MINGW)
550553
# Cygwin doesn't identify itself as Windows, and thus gets path::Style::posix

llvm/cmake/modules/HandleLLVMOptions.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,10 @@ else()
206206
message(FATAL_ERROR "Unknown value for LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING: \"${LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING}\"!")
207207
endif()
208208

209+
if(LLVM_EXPERIMENTAL_KEY_INSTRUCTIONS)
210+
add_compile_definitions(EXPERIMENTAL_KEY_INSTRUCTIONS)
211+
endif()
212+
209213
if( LLVM_REVERSE_ITERATION )
210214
set( LLVM_ENABLE_REVERSE_ITERATION 1 )
211215
endif()

0 commit comments

Comments
 (0)