Merge pull request #5576 from MicrosoftDocs/main

5/24/2024 AM Publish

Author: Albertyang0

docs/code-quality/clang-tidy.md

@@ -3,7 +3,7 @@ title: Using Clang-Tidy in Visual Studio
 description: "How to use Clang-Tidy in Visual Studio for Microsoft C++ code analysis."
 ms.date: 03/1/2022
 ms.topic: "conceptual"
-f1_keywords: ["vs.codeanalysis.clangtidy"]
+f1_keywords: ["vs.codeanalysis.clangtidy","vs.codeanalysis.propertypages.ClangTidyToolPath"]
 ---
 # Using Clang-Tidy in Visual Studio
 
@@ -90,6 +90,10 @@ Clang-Tidy runs result in warnings displayed in the Error List, and as in-editor
 
 By default, Clang-Tidy does not set any checks when enabled. To see the list of checks in the command-line version, run `clang-tidy -list-checks` in a developer command prompt. You can configure the checks that Clang-Tidy runs inside Visual Studio. In the project Property Pages dialog, open the **Configuration Properties** > **Code Analysis** > **Clang-Tidy** page. Enter checks to run in the **Clang-Tidy Checks** property. A good default set is `clang-analyzer-*`. This property value is provided to the **`--checks`** argument of the tool. Any further configuration can be included in custom *`.clang-tidy`* files. For more information, see the [Clang-Tidy documentation on LLVM.org](https://clang.llvm.org/extra/clang-tidy/).
 
+## Clang-Tidy Tool Directory
+
+If you'd like to have custom rules built into your clang-tidy executable and run it in Microsoft Visual Studio, you can change the path to the executable that Visual Studio runs. In the project Property Pages dialog, open the **Configuration Properties** > **Code Analysis** > **Clang-Tidy** page. Manually type in the path or **Browse** and select the path under the **Clang-Tidy Tool Directory** property. The new executable is used once the change is saved, and the app is recompiled.
+
 ## See also
 
 [Clang/LLVM support for MSBuild projects](https://devblogs.microsoft.com/cppblog/clang-llvm-support-for-msbuild-projects/)\

docs/error-messages/compiler-warnings/compiler-warning-level-2-c4150.md

@@ -1,30 +1,84 @@
 ---
 description: "Learn more about: Compiler Warning (level 2) C4150"
-title: "Compiler Warning (level 2) C4150"
+title: Compiler warning (level 2) C4150
 ms.date: "11/04/2016"
 f1_keywords: ["C4150"]
 helpviewer_keywords: ["C4150"]
-ms.assetid: ff1760ec-0d9f-4d45-b797-94261624becf
 ---
 # Compiler Warning (level 2) C4150
 
-deletion of pointer to incomplete type 'type'; no destructor called
+> deletion of pointer to incomplete type 'type'; no destructor called
 
-The **`delete`** operator is called to delete a type that was declared but not defined, so the compiler cannot find a destructor.
+The `delete` operator is called to delete a type that was declared but not defined. The compiler can't find the destructor to call because the definition isn't in the same translation unit as the `delete`.
 
-The following sample generates C4150:
+## Example
+
+The following sample generates C4150 by declaring but not defining `class IncClass`:
 
 ```cpp
-// C4150.cpp
 // compile with: /W2
-class  IncClass;
+class IncClass;
+
+void NoDestruct( IncClass* pIncClass )
+{
+   delete pIncClass; // C4150
+}
+```
+
+To fix the issue, put the definition of `IncClass` in the same file as the `delete`. If the class is declared in a header file, it can be added to the file using `#include`. If the class isn't declared in a header file, the `NoDestruct` function definition may need to be moved into the same file as the `IncClass` definition.
+
+```cpp
+// compile with: /W2
+#include "IncClass.h"
 
 void NoDestruct( IncClass* pIncClass )
 {
    delete pIncClass;
-} // C4150, define class to resolve
+}
+```
+
+C4150 will be emitted when the class is defined after the destructor call in the same file. In the following example `IncClass` is declared before being used, but defined after the `delete`:
+
+```cpp
+// C4150.cpp
+// compile with: /W2
+class IncClass;
 
-int main()
+void NoDestruct( IncClass* pIncClass )
 {
+   delete pIncClass; // C4150
 }
+
+class IncClass
+{
+public:
+    IncClass() = default;
+    ~IncClass() = default;
+};
 ```
+In this scenario, the use of `delete` needs to be after the class definition.
+```cpp
+// C4150.cpp
+// compile with: /W2
+class  IncClass;
+
+void NoDestruct( IncClass* pIncClass );
+
+class IncClass
+{
+public:
+    IncClass() = default;
+    ~IncClass() = default;
+};
+
+void NoDestruct( IncClass* pIncClass )
+{
+   delete pIncClass;
+}
+
+```
+
+## See also
+
+* [Projects and build systems](../../build/projects-and-build-systems-cpp.md)
+* [Source files and source programs](../../c-language/source-files-and-source-programs.md)