acrolinx

Author: TylerMSFT

docs/code-quality/c26832.md

@@ -1,7 +1,7 @@
 ---
 title: Warning C26832
 description: "Describes the Microsoft C/C++ code analysis warning C26832, its causes, and how to address it."
-ms.date: 03/06/2023
+ms.date: 03/20/2023
 f1_keywords: ["C26832", "ALLOCATION_POTENTIAL_OVERFLOW_AFTER_CAST"]
 helpviewer_keywords: ["C26832"]
 ---

docs/code-quality/c26833.md

@@ -1,7 +1,7 @@
 ---
 title: Warning C26833
 description: "Describes the Microsoft C/C++ code analysis warning C26833, its causes, and how to address it."
-ms.date: 03/06/2023
+ms.date: 03/20/2023
 f1_keywords: ["C26833", "ALLOCATION_POTENTIAL_OVERFLOW_BEFORE_CHECK"]
 helpviewer_keywords: ["C26833"]
 ---
@@ -11,7 +11,7 @@ helpviewer_keywords: ["C26833"]
 
 ## Remarks
 
-This waraning reports that the size specified for an allocation may be the result of a numerical overflow. For example:
+This warning reports that the size specified for an allocation may be the result of a numerical overflow. For example:
 
 ```cpp
 void* SmallAlloc(int);
@@ -30,7 +30,7 @@ void foo(unsigned i, unsigned j)
 }
 ```
 
-The check for `size > 50` is too late. If `i + j` overflows, it produces a small value that will pass the check. Then, `SmallAlloc` will allocate a buffer smaller than expected. That will likely lead to out of bounds attempts to access the buffer later on. This code pattern can result in remote code execution vulnerabilities.
+The check for `size > 50` is too late. If `i + j` overflows, it produces a small value that passes the check. Then, `SmallAlloc` allocates a buffer smaller than expected. That will likely lead to out of bounds attempts to access the buffer later on. This code pattern can result in remote code execution vulnerabilities.
 
 This check applies to common allocation functions like `new`, `malloc`, and `VirtualAlloc`. The check also applies to custom allocator functions that have `alloc` (case insensitive) in the function name.
 
@@ -40,7 +40,7 @@ This warning is available in Visual Studio 2022 version 17.7 and later versions.
 
 ## Example
 
-To fix the previous code example, make sure `i+j` cannot overflow. For example:
+To fix the previous code example, make sure `i+j` can't overflow. For example:
 
 ```cpp
 void* SmallAlloc(int);

docs/code-quality/c26835.md

@@ -11,7 +11,7 @@ helpviewer_keywords: ["C26835"]
 
 ## Remarks
 
-When `RtlCompareMemory`'s return value is treated as a boolean, it evaluates to true when there is at least 1 equal byte before finding a difference. Moreover, comparing the result of `RtlCompareMemory` to 0 evaluates to false if there is at least 1 matching byte. This behavior may be unexpected because it is different from other comparison functions such as `strcmp`, making the code harder to understand. To check for equality, consider using `RtlEqualMemory` instead.
+When `RtlCompareMemory`'s return value is treated as a boolean, it evaluates to true when there is at least 1 equal byte before finding a difference. Moreover, comparing the result of `RtlCompareMemory` to 0 evaluates to false if there is at least 1 matching byte. This behavior may be unexpected because it's different from other comparison functions such as `strcmp`, making the code harder to understand. To check for equality, consider using `RtlEqualMemory` instead.
 
 This warning is available in Visual Studio 2022 version 17.7 and later versions.
 
@@ -41,5 +41,5 @@ int foo(const void* ptr)
 
 ## See also
 
-[`RtlEqualMemory` macro (`wdm.h`)](/windows-hardware/drivers/ddi/wdm/nf-wdm-rtlequalmemory.md)\
-[`RtlCompareMemory` function (`wdm.h`)](/windows-hardware/drivers/ddi/wdm/nf-wdm-rtlequalmemory.md)
+[`RtlEqualMemory` macro (`wdm.h`)](https://learn.microsoft.com/windows-hardware/drivers/ddi/wdm/nf-wdm-rtlequalmemory)\
+[`RtlCompareMemory` function (`wdm.h`)](https://learn.microsoft.com/windows-hardware/drivers/ddi/wdm/nf-wdm-rtlcomparememory)